From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] checkstack: fix perl warnings
Date: Mon, 14 Jan 2008 11:19:34 -0800 [thread overview]
Message-ID: <20080114111934.0460c736@deepthought> (raw)
In-Reply-To: <20080114111602.591fe1a4@deepthought>
If you enable perl warnings on this script, it shows a couple of problems:
Parentheses missing around "my" list at scripts/checkstack.pl line 105.
Useless use of a variable in void context at scripts/checkstack.pl line 105.
Use of uninitialized value in string eq at scripts/checkstack.pl line 33.
Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
--- a/scripts/checkstack.pl 2008-01-14 11:10:57.000000000 -0800
+++ b/scripts/checkstack.pl 2008-01-14 11:11:56.000000000 -0800
@@ -30,7 +30,7 @@
my (@stack, $re, $x, $xs);
{
my $arch = shift;
- if ($arch eq "") {
+ if (! defined $arch) {
$arch = `uname -m`;
chomp $arch;
}
@@ -102,7 +102,8 @@ sub bysize($) {
#
my $funcre = qr/^$x* <(.*)>:$/;
my $func;
-my $file, $lastslash;
+my $file;
+my $lastslash;
while (my $line = <STDIN>) {
if ($line =~ m/$funcre/) {
parent reply other threads:[~2008-01-14 19:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20080114111602.591fe1a4@deepthought>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114111934.0460c736@deepthought \
--to=stephen.hemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.