All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Pignat <marc.pignat@hevs.ch>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH, take 2] watchdog on generic gpio
Date: Mon, 14 Jan 2008 14:01:33 +0100	[thread overview]
Message-ID: <200801141401.33783.marc.pignat@hevs.ch> (raw)
In-Reply-To: <200801141206.39858.florian.fainelli@telecomint.eu>

Hi Florian!

On Monday 14 January 2008, Florian Fainelli wrote:
...
> I would like this function to be supplied by the platform_data structure 
> because as I mentioned before, not all GPIO connected watchdog will simply 
> need a single bit to be toggled, but also sometimes a full GPIO line.
I understand your wish, but...
You told me that your plaform doesn't implement the generic gpio interface
(yet?), so this driver can't work for you.

...
> 
> If we do not supply any specific callback to keepalive the watchdog let's just 
> assume we need a single bit to be toggled if this is ok with you ?
This is not the only function to be changed, start, stop and keepalive (and
probably suspend/resume) should be changed, and when the 'Uniform Watchdog
Device Driver' will be merged, writing your driver dealing with more gpio will
be almost trivial.

Please make sure to look a the right place, the git tree for the unified
driver you have given is 17 month old... here is the latest:
http://git.kernel.org/?p=linux/kernel/git/wim/linux-2.6-watchdog-mm.git;a=summary

I'm trying to get this work merged because I use it, it works for me and I'm
almost sure I haven't got the only embedded system using a max823 connected
to a gpio.

Let me know if you want some help implementing your driver!

Regards

Marc

  reply	other threads:[~2008-01-14 13:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-14 10:03 [RFC, PATCH, take 2] watchdog on generic gpio Marc Pignat
2008-01-14 11:06 ` Florian Fainelli
2008-01-14 13:01   ` Marc Pignat [this message]
2008-01-14 14:03     ` Florian Fainelli
2008-01-14 14:59       ` Marc Pignat
2008-01-14 15:57       ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801141401.33783.marc.pignat@hevs.ch \
    --to=marc.pignat@hevs.ch \
    --cc=florian.fainelli@telecomint.eu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.