From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JEQJV-00034E-0k for mharc-grub-devel@gnu.org; Mon, 14 Jan 2008 09:29:21 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JEQJT-000349-A1 for grub-devel@gnu.org; Mon, 14 Jan 2008 09:29:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JEQJQ-00033x-UO for grub-devel@gnu.org; Mon, 14 Jan 2008 09:29:18 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JEQJQ-00033u-P3 for grub-devel@gnu.org; Mon, 14 Jan 2008 09:29:16 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JEQJQ-0006nU-F9 for grub-devel@gnu.org; Mon, 14 Jan 2008 09:29:16 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JEQJM-0002tO-II for grub-devel@gnu.org; Mon, 14 Jan 2008 15:29:15 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JEQHj-0007KU-2l for grub-devel@gnu.org; Mon, 14 Jan 2008 15:27:31 +0100 Date: Mon, 14 Jan 2008 15:27:31 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080114142731.GA28109@thorin> References: <20080113203041.GA25702@thorin> <1200320439.13534.4.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1200320439.13534.4.camel@dv> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix endianess in IEEE-1275 integer properties X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 14:29:19 -0000 On Mon, Jan 14, 2008 at 09:20:39AM -0500, Pavel Roskin wrote: > On Sun, 2008-01-13 at 21:30 +0100, Robert Millan wrote: > > Integer properties are always in big endian. This (incomplete) patch is my > > suggested approach to deal with this. I'd like to receive input about it > > before I complete it (checking all calls to grub_ieee1275_get_property > > through GRUB and replacing with grub_ieee1275_get_integer_property when > > appropiate). > > > > Again, some testing on Apple/IBM/Genesi hardware would be nice. > > It doesn't apply cleanly, It depends on my previous patch, "restrict parsing of `available'". > and I don't see how the result of > grub_ieee1275_get_integer_property() is used. If something went wrong, you'd most likely see those claim-related errors you're familiar with ;-) -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)