From mboxrd@z Thu Jan  1 00:00:00 1970
From: teigland@sourceware.org <teigland@sourceware.org>
Date: 14 Jan 2008 15:29:43 -0000
Subject: [Cluster-devel] cluster/gfs-kernel/src/dlm group.c
Message-ID: <20080114152943.23907.qmail@sourceware.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	teigland at sourceware.org	2008-01-14 15:29:43

Modified files:
	gfs-kernel/src/dlm: group.c 

Log message:
	bz 353311
	
	Disassembling the module, the oops appears to be when dereferencing
	dlm->mg_nodes.  I see one place where the mg_nodes list is modified
	without holding mg_nodes_lock, and that's in release_mg_nodes().

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/dlm/group.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.8.2.2&r2=1.8.2.3

--- cluster/gfs-kernel/src/dlm/Attic/group.c	2005/06/29 07:28:21	1.8.2.2
+++ cluster/gfs-kernel/src/dlm/Attic/group.c	2008/01/14 15:29:42	1.8.2.3
@@ -751,7 +751,9 @@
 	kcl_unregister_service(dlm->mg_local_id);
 
 	release_jid(dlm);
+	down(&dlm->mg_nodes_lock);
 	release_mg_nodes(dlm);
+	up(&dlm->mg_nodes_lock);
 }
 
 /*