Re: [PATCH] checkpatch.pl: show how to read from stdin

[Andy Whitcroft <apw@shadowen.org>]

On Fri, Jan 11, 2008 at 06:06:35PM +0100, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Acked-by: Jiri Slaby <jirislaby@gmail.com>

As an absolute minimum this seems reasonable to me.  I guess we could
make no arguments default to '-' also.  There are up and downsides to
doing that, as currently no arguments currently tell you the usage and
with this patch would point clearly out the '-' option.  Just assuming
stding would lose easy access to usage, which may actually be more
confusing for the beginner.  Hmmm.  Cirtainly will include this
documentation change if nothing else.

> ---
>  scripts/checkpatch.pl |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux/scripts/checkpatch.pl
> ===================================================================
> --- linux.orig/scripts/checkpatch.pl
> +++ linux/scripts/checkpatch.pl
> @@ -53,6 +53,7 @@ if ($#ARGV < 0) {
>  	print "         --file       => check a source file\n";
>  	print "         --strict     => enable more subjective tests\n";
>  	print "         --root       => path to the kernel tree root\n";
> +	print "When patchfile is -, read standard input.\n";
>  	exit(1);
>  }

-apw