From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: prasanna@in.ibm.com, ananth@in.ibm.com, anil.s.keshavamurthy@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] kprobe: missing cast
Date: Mon, 14 Jan 2008 19:21:55 -0800 [thread overview]
Message-ID: <20080114192155.2d6982ea@speedy> (raw)
Fix warning from missing cast, maybe a result of the x86 merge?
Signed-off-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
CC arch/x86/kernel/kprobes_32.o
arch/x86/kernel/kprobes_32.c: In function ‘longjmp_break_handler’:
arch/x86/kernel/kprobes_32.c:729: warning: comparison of distinct pointer types lacks a cast
--- a/arch/x86/kernel/kprobes_32.c 2008-01-14 19:18:01.000000000 -0800
+++ b/arch/x86/kernel/kprobes_32.c 2008-01-14 19:18:08.000000000 -0800
@@ -726,7 +726,7 @@ int __kprobes longjmp_break_handler(stru
struct jprobe *jp = container_of(p, struct jprobe, kp);
if ((addr > (u8 *) jprobe_return) && (addr < (u8 *) jprobe_return_end)) {
- if (®s->esp != kcb->jprobe_saved_esp) {
+ if ((unsigned long *) ®s->esp != kcb->jprobe_saved_esp) {
struct pt_regs *saved_regs = &kcb->jprobe_saved_regs;
printk("current esp %p does not match saved esp %p\n",
®s->esp, kcb->jprobe_saved_esp);
next reply other threads:[~2008-01-15 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 3:21 Stephen Hemminger [this message]
2008-01-16 4:52 ` [PATCH] kprobe: missing cast Ananth N Mavinakayanahalli
2008-01-16 4:58 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114192155.2d6982ea@speedy \
--to=stephen.hemminger@vyatta.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.