From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] nand: fsl_upm: convert to updated MTD NAND infrastructure
Date: Mon, 14 Jan 2008 23:09:57 +0300 [thread overview]
Message-ID: <20080114200957.GC24168@localhost.localdomain> (raw)
In-Reply-To: <20080114200611.GA3442@localhost.localdomain>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/mtd/nand/fsl_upm.c | 68 +++++++++++--------------------------------
include/linux/mtd/fsl_upm.h | 3 ++
2 files changed, 20 insertions(+), 51 deletions(-)
diff --git a/drivers/mtd/nand/fsl_upm.c b/drivers/mtd/nand/fsl_upm.c
index 5cc410a..4775cdc 100644
--- a/drivers/mtd/nand/fsl_upm.c
+++ b/drivers/mtd/nand/fsl_upm.c
@@ -61,51 +61,28 @@ static void fsl_upm_setup(struct fsl_upm *upm)
eieio();
}
-static void fun_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
- int page_addr)
+static void fun_cmd_ctrl(struct mtd_info *mtd, int cmd, unsigned int ctrl)
{
struct nand_chip *chip = mtd->priv;
struct fsl_upm_nand *fun = chip->priv;
- fsl_upm_start_pattern(&fun->upm, fun->upm_cmd_offset);
-
- if (command == NAND_CMD_SEQIN) {
- int readcmd;
-
- if (column >= mtd->oobblock) {
- /* OOB area */
- column -= mtd->oobblock;
- readcmd = NAND_CMD_READOOB;
- } else if (column < 256) {
- /* First 256 bytes --> READ0 */
- readcmd = NAND_CMD_READ0;
- } else {
- column -= 256;
- readcmd = NAND_CMD_READ1;
- }
- fsl_upm_run_pattern(&fun->upm, fun->width, readcmd);
- }
-
- fsl_upm_run_pattern(&fun->upm, fun->width, command);
+ if (!(ctrl & fun->last_ctrl)) {
+ fsl_upm_end_pattern(&fun->upm);
- fsl_upm_end_pattern(&fun->upm);
+ if (cmd == NAND_CMD_NONE)
+ return;
- fsl_upm_start_pattern(&fun->upm, fun->upm_addr_offset);
-
- if (column != -1)
- fsl_upm_run_pattern(&fun->upm, fun->width, column);
+ fun->last_ctrl = ctrl & (NAND_ALE | NAND_CLE);
+ }
- if (page_addr != -1) {
- fsl_upm_run_pattern(&fun->upm, fun->width, page_addr);
- fsl_upm_run_pattern(&fun->upm, fun->width,
- (page_addr >> 8) & 0xFF);
- if (chip->chipsize > (32 << 20)) {
- fsl_upm_run_pattern(&fun->upm, fun->width,
- (page_addr >> 16) & 0x0f);
- }
+ if (ctrl & NAND_CTRL_CHANGE) {
+ if (ctrl & NAND_ALE)
+ fsl_upm_start_pattern(&fun->upm, fun->upm_addr_offset);
+ else if (ctrl & NAND_CLE)
+ fsl_upm_start_pattern(&fun->upm, fun->upm_cmd_offset);
}
- fsl_upm_end_pattern(&fun->upm);
+ fsl_upm_run_pattern(&fun->upm, fun->width, cmd);
if (fun->wait_pattern) {
/*
@@ -119,13 +96,6 @@ static void fun_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
}
}
-static void nand_write_byte(struct mtd_info *mtd, u_char byte)
-{
- struct nand_chip *chip = mtd->priv;
-
- out_8(chip->IO_ADDR_W, byte);
-}
-
static u8 nand_read_byte(struct mtd_info *mtd)
{
struct nand_chip *chip = mtd->priv;
@@ -164,10 +134,6 @@ static int nand_verify_buf(struct mtd_info *mtd, const u_char *buf, int len)
return 0;
}
-static void nand_hwcontrol(struct mtd_info *mtd, int cmd)
-{
-}
-
static int nand_dev_ready(struct mtd_info *mtd)
{
struct nand_chip *chip = mtd->priv;
@@ -184,14 +150,14 @@ int fsl_upm_nand_init(struct nand_chip *chip, struct fsl_upm_nand *fun)
fsl_upm_setup(&fun->upm);
+ fun->last_ctrl = NAND_CLE;
+
chip->priv = fun;
chip->chip_delay = fun->chip_delay;
- chip->eccmode = NAND_ECC_SOFT;
- chip->cmdfunc = fun_cmdfunc;
- chip->hwcontrol = nand_hwcontrol;
+ chip->ecc.mode = NAND_ECC_SOFT;
+ chip->cmd_ctrl = fun_cmd_ctrl;
chip->read_byte = nand_read_byte;
chip->read_buf = nand_read_buf;
- chip->write_byte = nand_write_byte;
chip->write_buf = nand_write_buf;
chip->verify_buf = nand_verify_buf;
chip->dev_ready = nand_dev_ready;
diff --git a/include/linux/mtd/fsl_upm.h b/include/linux/mtd/fsl_upm.h
index 634ff02..5f0016d 100644
--- a/include/linux/mtd/fsl_upm.h
+++ b/include/linux/mtd/fsl_upm.h
@@ -32,6 +32,9 @@ struct fsl_upm_nand {
int wait_pattern;
int (*dev_ready)(void);
int chip_delay;
+
+ /* no need to fill */
+ int last_ctrl;
};
extern int fsl_upm_nand_init(struct nand_chip *chip, struct fsl_upm_nand *fun);
--
1.5.2.2
next prev parent reply other threads:[~2008-01-14 20:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 17:50 [U-Boot-Users] [PATCH v2 0/5] mpc83xx: MPC8360E-RDK related patches Anton Vorontsov
2008-01-09 17:57 ` [U-Boot-Users] [PATCH 1/5] mpc83xx: add "fsl, qe" compatible fixups Anton Vorontsov
2008-01-09 17:57 ` [U-Boot-Users] [PATCH 2/5] mpc83xx: add support for the MPC8360E-RDK Anton Vorontsov
2008-01-09 17:57 ` [U-Boot-Users] [PATCH 3/5] nand: FSL UPM NAND driver Anton Vorontsov
2008-01-10 17:31 ` Stefan Roese
2008-01-14 20:06 ` Anton Vorontsov
2008-01-14 20:09 ` [U-Boot-Users] [PATCH v2 1/2] " Anton Vorontsov
2008-01-16 13:16 ` Stefan Roese
2008-01-14 20:09 ` [U-Boot-Users] [PATCH v2 2/2] mpc83xx: MPC8360E-RDK: add support for NAND Anton Vorontsov
2008-01-14 20:09 ` Anton Vorontsov [this message]
2008-01-16 13:19 ` [U-Boot-Users] [PATCH] nand: fsl_upm: convert to updated MTD NAND infrastructure Stefan Roese
2008-01-15 8:41 ` [U-Boot-Users] [PATCH 3/5] nand: FSL UPM NAND driver Stefan Roese
2008-01-09 17:57 ` [U-Boot-Users] [PATCH 4/5] mpc83xx: MPC8360E-RDK: add support for NAND Anton Vorontsov
2008-01-16 18:31 ` Kim Phillips
2008-01-17 12:40 ` Anton Vorontsov
2008-01-09 17:58 ` [U-Boot-Users] [PATCH 5/5] mpc83xx: UEC: add support for Broadcom BCM5481 Gigabit PHY Anton Vorontsov
2008-01-10 20:41 ` Ben Warren
2008-01-10 21:10 ` Peter Barada
2008-01-11 5:26 ` Ben Warren
2008-01-11 4:00 ` [U-Boot-Users] [PATCH v2 0/5] mpc83xx: MPC8360E-RDK related patches Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080114200957.GC24168@localhost.localdomain \
--to=avorontsov@ru.mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.