All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Benjamin Coddington <Benjamin.Coddington@uvm.edu>,
	linux-nfs@vger.kernel.org
Subject: Re: Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock?
Date: Mon, 14 Jan 2008 16:09:22 -0500	[thread overview]
Message-ID: <20080114210922.GF16926@fieldses.org> (raw)
In-Reply-To: <1200343018.7470.56.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>

On Mon, Jan 14, 2008 at 03:36:58PM -0500, Trond Myklebust wrote:
> 
> On Mon, 2008-01-14 at 15:28 -0500, Benjamin Coddington wrote:
> > Trond Myklebust wrote:
> > > That shouldn't be the case in standard 2.6.22 unless you've also applied
> > > the NFS_ALL patches. In that case, there is a fix (which has also been
> > > applied to mainline) in
> > > 
> > >  http://client.linux-nfs.org/Linux-2.6.x/2.6.23-rc1/linux-2.6.23-001-fix_rpciod_down_race.dif
> > 
> > That fixed the problem -- still, do we care if we call async in 
> > gss_destroying_context?  On umount the server drops out from under the 
> > tasks..
> 
> It is useful when running against Solaris RPC servers, since they will
> actually respect the request to destroy the context. In the long run, we
> should fix up Linux servers to do the same.

There is actually code to handle the DESTROY token on the server, though
it probably hasn't been tested recently.

Hrm, and it isn't quite right.  This should fix it, though I'd be
happier if we could just remove the context here instead of having to
wait for the cache cleaner to come take care of it for us later.

--b.

commit c67f8448a564eec56ce4a7957978295cfb88f49f
Author: J. Bruce Fields <bfields@citi.umich.edu>
Date:   Mon Jan 14 16:05:07 2008 -0500

    svcrpc: ensure gss DESTROY tokens free contexts from cache
    
    If we don't do this then we'll end up with a pointless unusable context
    sitting in the cache until the time the original context would have
    expired.
    
    Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index e8ed848..481f984 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1126,6 +1126,7 @@ svcauth_gss_accept(struct svc_rqst *rqstp, __be32 *authp)
 	case RPC_GSS_PROC_DESTROY:
 		if (gss_write_verf(rqstp, rsci->mechctx, gc->gc_seq))
 			goto auth_err;
+		rsci->h.expiry_time = get_seconds();
 		set_bit(CACHE_NEGATIVE, &rsci->h.flags);
 		if (resv->iov_len + 4 > PAGE_SIZE)
 			goto drop;

  parent reply	other threads:[~2008-01-14 21:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 21:51 Strange lockup during unmount in 2.6.22 - maybe rpciod deadlock? Neil Brown
     [not found] ` <18310.37731.29874.582772-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-01-10 22:41   ` Trond Myklebust
2008-01-11  1:07     ` Neil Brown
     [not found]       ` <18310.49514.808155.132856-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-01-11  1:26         ` Trond Myklebust
     [not found]     ` <1200004896.13775.27.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-01-14 19:01       ` Benjamin Coddington
2008-01-14 19:31         ` Trond Myklebust
     [not found]           ` <1200339108.7470.45.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-01-14 20:28             ` Benjamin Coddington
2008-01-14 20:36               ` Trond Myklebust
     [not found]                 ` <1200343018.7470.56.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-01-14 21:09                   ` J. Bruce Fields [this message]
2008-02-19  5:34     ` Neil Brown
     [not found]       ` <18362.27251.619125.502340-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-02-19 19:26         ` Trond Myklebust
     [not found]           ` <1203449166.8156.85.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-02-19 23:18             ` Trond Myklebust
2008-02-21  5:16               ` Neil Brown
     [not found]                 ` <18365.2329.495660.107605-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-02-21 13:34                   ` Trond Myklebust
2008-02-21  4:58           ` Neil Brown
     [not found]             ` <18365.1274.387629.944796-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-02-21 12:16               ` Jeff Layton
2008-02-21 15:27               ` Trond Myklebust
2008-02-22  0:31                 ` Neil Brown
     [not found]                   ` <18366.6141.122127.181304-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-02-22  0:41                     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080114210922.GF16926@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Benjamin.Coddington@uvm.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.