diff for duplicates of <20080115002958.GA27597@linux-sh.org> diff --git a/a/1.txt b/N1/1.txt index fbcc370..6c629c1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -32,7 +32,7 @@ With vim you can use something like 'let c_space_errors=1' to see these. > +static bool gdrom_data_request(void) > +{ -> + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8; +> + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8; > +} > + Andrew first pointed this out, and this is still broken. Additionally, @@ -40,7 +40,7 @@ checkpatch _does_ complain about this: ERROR: use tabs not spaces #202: FILE: drivers/cdrom/gdrom.c:146: -+ ^Ireturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8;$ ++ ^Ireturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8;$ ERROR: use tabs not spaces #230: FILE: drivers/cdrom/gdrom.c:174: diff --git a/a/content_digest b/N1/content_digest index 6c3c8f0..703052d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,7 +5,7 @@ "ref\01200352635.6196.8.camel@localhost.localdomain\0" "From\0Paul Mundt <lethal@linux-sh.org>\0" "Subject\0Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast\0" - "Date\0Tue, 15 Jan 2008 00:29:58 +0000\0" + "Date\0Tue, 15 Jan 2008 09:29:58 +0900\0" "To\0Adrian McMenamin <adrian@newgolddream.dyndns.info>\0" "Cc\0Andrew Morton <akpm@linux-foundation.org>" Jens Axboe <jens.axboe@oracle.com> @@ -47,7 +47,7 @@ "\n" "> +static bool gdrom_data_request(void)\n" "> +{\n" - "> + \treturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8;\n" + "> + \treturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8;\n" "> +}\n" "> +\n" "Andrew first pointed this out, and this is still broken. Additionally,\n" @@ -55,7 +55,7 @@ "\n" "ERROR: use tabs not spaces\n" "#202: FILE: drivers/cdrom/gdrom.c:146:\n" - "+ ^Ireturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8;$\n" + "+ ^Ireturn (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) == 8;$\n" "\n" "ERROR: use tabs not spaces\n" "#230: FILE: drivers/cdrom/gdrom.c:174:\n" @@ -146,4 +146,4 @@ "remove_gdrom() needs to be __devexit, and you can wrap around it with\n" __devexit_p() in the gdrom_driver definition. -5af0593789deda34212efbeb7c2426634e29f2d16d5bab18f208a1c781c42296 +42bae26a8ad982b837575c116b03803cfeba97c30ae3d66db12c897776cea5ec
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.