All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] fix bug in virtio-rng
Date: Tue, 15 Jan 2008 11:02:00 +1100	[thread overview]
Message-ID: <200801151102.00640.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200801141831.35481.borntraeger@de.ibm.com>

On Tuesday 15 January 2008 04:31:35 Christian Borntraeger wrote:
> Rusty,
>
> I have seen an oops triggered by the following bug statement in
> virtio-rng:
>
> if (vq->vq_ops->add_buf(vq, &sg, 0, 1, &random_data) != 0)
> 	BUG();
>
> The problem is that we never called get_buf for complete buffers.
>
> The fix is simple: We have to free the buffer on interrupt to
> avoid a virtqueue "overflow".

Thanks, applied.

Rusty.

      reply	other threads:[~2008-01-15  0:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-14 17:31 [PATCH] fix bug in virtio-rng Christian Borntraeger
2008-01-15  0:02 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801151102.00640.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=borntraeger@de.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.