From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [0/31] Great change_page_attr patch series v2
Date: Tue, 15 Jan 2008 11:06:15 +0100 [thread overview]
Message-ID: <200801151106.15452.ak@suse.de> (raw)
In-Reply-To: <478C86E0.76E4.0078.0@novell.com>
On Tuesday 15 January 2008 10:11:44 Jan Beulich wrote:
> >>> Andi Kleen <ak@suse.de> 14.01.08 23:16 >>>
> >
> >Lots of improvements to change_page_attr(). Make it a lot more
> >efficient and fix various bugs.
> >
> >Changes against earlier version
> >
> >- Fixed some checkpatch.pl complaints
> >- Improved self test suite
> >- Fixed more reference bugs
> >- Fix NX handling on 32bit
> >- Remove some useless code there
> >- Few other random fixes
>
> The one concept that I'm missing (but that I can easily produce a follow-up
> patch for, as I had this in my c_p_a() changes) is the tracking and adjusting
> of the reference protection for a large page range that got fully converted
> to another type (namely relevant for .rodata if it exceeds 2/4 Mb), allowing
> to use a large page mapping in this case even for non-default mappings.
Ah -- i got rid of that by changing the rodata code to not do this
except for the debugging case
>>
CPA: Only unmap kernel init pages in text mapping when CONFIG_DEBUG_RODATA is set
Otherwise the kernel will likely always run with 4K pages instead of 2MB pages,
which is costly in terms of TLBs.
<<
But you're right that would be an useful feature. But wouldn't it require
aligning rodata to 2MB in the vmlinux to be really effective?
>
> Apart from the other comments, the whole series
>
> Acked-by: Jan Beulich <jbeulich@novell.com>
Thanks.
-Andi
next prev parent reply other threads:[~2008-01-15 10:09 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 22:16 [PATCH] [0/31] Great change_page_attr patch series v2 Andi Kleen
2008-01-14 22:16 ` [PATCH] [1/31] Shrink __PAGE_KERNEL/__PAGE_KERNEL_EXEC on non PAE kernels Andi Kleen
2008-01-14 22:16 ` [PATCH] [2/31] CPA: Do a simple self test at boot Andi Kleen
2008-01-15 8:47 ` Harvey Harrison
2008-01-15 9:59 ` Andi Kleen
2008-01-15 10:07 ` Harvey Harrison
2008-01-14 22:16 ` [PATCH] [3/31] Add pte accessors for the global bit Andi Kleen
2008-01-14 22:16 ` [PATCH] [4/31] Add pte_pgprot on i386 Andi Kleen
2008-01-15 13:00 ` Johannes Weiner
2008-01-14 22:16 ` [PATCH] [5/31] Don't drop NX bit in pte modifier functions for 32bit Andi Kleen
2008-01-14 22:16 ` [PATCH] [6/31] CPA: Undo white space changes Andi Kleen
2008-01-14 22:16 ` [PATCH] [7/31] Extract page table dumping code from i386 fault handler into dump_pagetable() Andi Kleen
2008-01-15 8:56 ` Harvey Harrison
2008-01-15 10:00 ` Andi Kleen
2008-01-15 10:05 ` Harvey Harrison
2008-01-14 22:16 ` [PATCH] [8/31] CPA: Return the page table level in lookup_address() Andi Kleen
2008-01-14 22:16 ` [PATCH] [9/31] CPA: Add simple self test at boot Andi Kleen
2008-01-15 10:37 ` Harvey Harrison
2008-01-14 22:16 ` [PATCH] [10/31] CPA: Change kernel_map_pages to not use c_p_a() Andi Kleen
2008-01-14 22:16 ` [PATCH] [11/31] CPA: Change 32bit back to init_mm semaphore locking Andi Kleen
2008-01-14 22:16 ` [PATCH] [12/31] CPA: CLFLUSH support in change_page_attr() Andi Kleen
2008-01-15 8:40 ` Jan Beulich
2008-01-15 9:57 ` Andi Kleen
2008-01-14 22:16 ` [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr Andi Kleen
2008-01-15 9:29 ` Harvey Harrison
2008-01-15 10:06 ` Andi Kleen
2008-01-15 10:15 ` Harvey Harrison
2008-01-15 10:25 ` Andi Kleen
2008-01-14 22:16 ` [PATCH] [14/31] CPA: Use page granuality TLB flushing " Andi Kleen
2008-01-14 22:16 ` [PATCH] [15/31] CPA: Don't flush the caches when the CPU supports self-snoop Andi Kleen
2008-01-14 22:16 ` [PATCH] [16/31] CPA: Use wbinvd() macro instead of inline assembly in 64bit c_p_a() Andi Kleen
2008-01-14 22:16 ` [PATCH] [17/31] CPA: Reorder TLB / cache flushes to follow Intel recommendation Andi Kleen
2008-01-14 22:16 ` [PATCH] [18/31] CPA: Make change_page_attr() more robust against use of PAT bits Andi Kleen
2008-01-14 22:16 ` [PATCH] [19/31] CPA: Limit cache flushing to pages that really change caching Andi Kleen
2008-01-15 8:46 ` Jan Beulich
2008-01-14 22:16 ` [PATCH] [20/31] CPA: Fix inaccurate comments in 64bit change_page_attr() Andi Kleen
2008-01-14 22:16 ` [PATCH] [21/31] CPA: Dump pagetable when inconsistency is detected Andi Kleen
2008-01-14 22:16 ` [PATCH] [22/31] CPA: Only queue actually unused page table pages for freeing Andi Kleen
2008-01-14 22:16 ` [PATCH] [23/31] CPA: Remove unnecessary masking of address Andi Kleen
2008-01-14 22:16 ` [PATCH] [24/31] CPA: Only unmap kernel init pages in text mapping when CONFIG_DEBUG_RODATA is set Andi Kleen
2008-01-14 22:16 ` [PATCH] [25/31] CPA: Always do full TLB flush when splitting large pages Andi Kleen
2008-01-14 22:16 ` [PATCH] [26/31] CPA: Fix reference counting when changing already changed pages Andi Kleen
2008-01-15 9:05 ` Jan Beulich
2008-01-15 10:04 ` Andi Kleen
2008-01-15 12:00 ` Jan Beulich
2008-01-14 22:17 ` [PATCH] [27/31] CPA: Change comments of external interfaces to kerneldoc format Andi Kleen
2008-01-14 22:50 ` Randy Dunlap
2008-01-15 0:49 ` Andi Kleen
2008-01-14 22:17 ` [PATCH] [28/31] CPA: Make kernel_text test match boot mapping initialization Andi Kleen
2008-01-14 22:17 ` [PATCH] [29/31] CPA: Add a BUG_ON checking for someone setting the kernel text NX Andi Kleen
2008-01-14 22:17 ` [PATCH] [30/31] Remove set_kernel_exec Andi Kleen
2008-01-14 22:17 ` [PATCH] [31/31] Clean up pte_exec Andi Kleen
2008-01-15 9:11 ` [PATCH] [0/31] Great change_page_attr patch series v2 Jan Beulich
2008-01-15 10:06 ` Andi Kleen [this message]
2008-01-15 11:55 ` Jan Beulich
2008-01-15 12:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801151106.15452.ak@suse.de \
--to=ak@suse.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.