From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Lameter <clameter@sgi.com>,
ebiederm@xmission.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: checking aperture report for node instead of cpu
Date: Tue, 15 Jan 2008 14:22:53 +0100 [thread overview]
Message-ID: <20080115132253.GC7025@elte.hu> (raw)
In-Reply-To: <200801141739.35448.yinghai.lu@sun.com>
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> - printk(KERN_INFO "CPU %d: aperture @ %Lx size %u MB\n",
> - num-24, aper_base, aper_size>>20);
> + printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n",
> + node++, aper_base, aper_size >> 20);
please dont put side-effects into printks. (put the node++ iteration out
into a separate line) Your patch looks fine otherwise.
Ingo
next prev parent reply other threads:[~2008-01-15 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 3:14 [PATCH] x86-64: disable the GART early Yinghai Lu
2008-01-11 7:54 ` [PATCH] x86-64: disable the GART early v2 Yinghai Lu
2008-01-11 8:14 ` Ingo Molnar
2008-01-11 8:34 ` Yinghai Lu
2008-01-11 21:38 ` [PATCH] x86-64: fix e820 for GART or disable the GART early Yinghai Lu
2008-01-12 10:07 ` [PATCH] x86-64: disable the GART early v2 Yinghai Lu
2008-01-14 8:35 ` Ingo Molnar
2008-01-15 1:39 ` [PATCH] x86_64: checking aperture report for node instead of cpu Yinghai Lu
2008-01-15 13:22 ` Ingo Molnar [this message]
2008-01-15 18:31 ` [PATCH] x86_64: checking aperture report for node instead of cpu v2 Yinghai Lu
2008-01-18 13:02 ` [PATCH] x86_64: checking aperture report for node instead of?cpu v2 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115132253.GC7025@elte.hu \
--to=mingo@elte.hu \
--cc=Yinghai.Lu@Sun.COM \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.