From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JEpRi-0001kg-Ko for mharc-grub-devel@gnu.org; Tue, 15 Jan 2008 12:19:30 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JEpRh-0001jA-86 for grub-devel@gnu.org; Tue, 15 Jan 2008 12:19:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JEpRe-0001gv-TZ for grub-devel@gnu.org; Tue, 15 Jan 2008 12:19:27 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JEpRe-0001gn-L1 for grub-devel@gnu.org; Tue, 15 Jan 2008 12:19:26 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JEpRe-0007BW-B6 for grub-devel@gnu.org; Tue, 15 Jan 2008 12:19:26 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JEpRc-0005Kr-3Y for grub-devel@gnu.org; Tue, 15 Jan 2008 18:19:25 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JEpQ3-0003p0-5k for grub-devel@gnu.org; Tue, 15 Jan 2008 18:17:47 +0100 Date: Tue, 15 Jan 2008 18:17:47 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080115171747.GA14625@thorin> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [PATCH] improve grub_mm_init_region() debug message X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2008 17:19:29 -0000 --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline This has bothered me for a while. By changing %u to %p this debug message becomes actually useful for checking offset problems. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.) --uAKRQypu60I7Lcqm Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="memdebug.diff" * kern/mm.c (grub_mm_init_region): Improve debug message. diff -u -x configure -x config.h.in -ur grub2/kern/mm.c memdebug/kern/mm.c --- grub2/kern/mm.c 2007-12-30 09:52:04.000000000 +0100 +++ memdebug/kern/mm.c 2008-01-15 18:07:14.000000000 +0100 @@ -143,7 +143,7 @@ grub_mm_header_t h; grub_mm_region_t r, *p, q; - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", addr, (unsigned int) size); + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n", addr, addr + size); /* If this region is too small, ignore it. */ if (size < GRUB_MM_ALIGN * 2) --uAKRQypu60I7Lcqm--