All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [RFC][PATCH] Modify loop device to be able to manage partitions of the image disk
Date: Tue, 15 Jan 2008 18:27:45 +0000	[thread overview]
Message-ID: <20080115182745.GY17783@redhat.com> (raw)
In-Reply-To: <120042137328-git-send-email-Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>

On Tue, Jan 15, 2008 at 07:22:53PM +0100, Laurent Vivier wrote:
> As it should be useful to be able to mount partition from a 
> disk image, (and as I need a break in my bug hunting) I've 
> modified the loop driver to mount raw disk image.
> 
> To not break original loop device, as we have to change minor 
> numbers to manage partitions, a new parameter is added to the module:

I don't see the point in modifying the loop device driver when you
can already access the partitions with existing device mapper
functionality & tools.

# losetup  -f /var/lib/xen/images/fc6pvi386.img
# kpartx -l /dev/loop0
loop0p1 : 0 208782 /dev/loop0 63
loop0p2 : 0 10265535 /dev/loop0 208845
# kpartx -a /dev/loop0
# ls /dev/mapper/loop0p*
/dev/mapper/loop0p1  /dev/mapper/loop0p2
# mount /dev/mapper/loop0p1  /mnt/
# ls /mnt/
config-2.6.18-20.el5xen      lost+found                   vmlinuz-2.6.18-20.el5xen
grub                         symvers-2.6.18-20.el5xen.gz  xen.gz-2.6.18-20.el5
initrd-2.6.18-20.el5xen.img  System.map-2.6.18-20.el5xen  xen-syms-2.6.18-20.el5

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [kvm-devel] [RFC][PATCH] Modify loop device to be able to manage partitions of the image disk
Date: Tue, 15 Jan 2008 18:27:45 +0000	[thread overview]
Message-ID: <20080115182745.GY17783@redhat.com> (raw)
In-Reply-To: <120042137328-git-send-email-Laurent.Vivier@bull.net>

On Tue, Jan 15, 2008 at 07:22:53PM +0100, Laurent Vivier wrote:
> As it should be useful to be able to mount partition from a 
> disk image, (and as I need a break in my bug hunting) I've 
> modified the loop driver to mount raw disk image.
> 
> To not break original loop device, as we have to change minor 
> numbers to manage partitions, a new parameter is added to the module:

I don't see the point in modifying the loop device driver when you
can already access the partitions with existing device mapper
functionality & tools.

# losetup  -f /var/lib/xen/images/fc6pvi386.img
# kpartx -l /dev/loop0
loop0p1 : 0 208782 /dev/loop0 63
loop0p2 : 0 10265535 /dev/loop0 208845
# kpartx -a /dev/loop0
# ls /dev/mapper/loop0p*
/dev/mapper/loop0p1  /dev/mapper/loop0p2
# mount /dev/mapper/loop0p1  /mnt/
# ls /mnt/
config-2.6.18-20.el5xen      lost+found                   vmlinuz-2.6.18-20.el5xen
grub                         symvers-2.6.18-20.el5xen.gz  xen.gz-2.6.18-20.el5
initrd-2.6.18-20.el5xen.img  System.map-2.6.18-20.el5xen  xen-syms-2.6.18-20.el5

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

  parent reply	other threads:[~2008-01-15 18:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15 18:22 [RFC][PATCH] Modify loop device to be able to manage partitions of the image disk Laurent Vivier
2008-01-15 18:22 ` [Qemu-devel] " Laurent Vivier
     [not found] ` <120042137328-git-send-email-Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
2008-01-15 18:27   ` Daniel P. Berrange [this message]
2008-01-15 18:27     ` [Qemu-devel] Re: [kvm-devel] " Daniel P. Berrange
     [not found]     ` <20080115182745.GY17783-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-15 23:40       ` [Qemu-devel] " Laurent Vivier
2008-01-15 23:40         ` [Qemu-devel] Re: [kvm-devel] " Laurent Vivier
2008-01-15 23:54         ` [Qemu-devel] " Daniel P. Berrange
2008-01-15 23:54           ` [Qemu-devel] Re: [kvm-devel] " Daniel P. Berrange
     [not found]           ` <20080115235438.GB30528-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-01-16  0:30             ` [Qemu-devel] " Laurent Vivier
2008-01-16  0:30               ` [Qemu-devel] Re: [kvm-devel] " Laurent Vivier
2008-01-16 14:57               ` [Qemu-devel] " Anthony Liguori
2008-01-16 14:57                 ` [kvm-devel] " Anthony Liguori
     [not found]                 ` <478E1B57.7090609-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-16 15:55                   ` Laurent Vivier
2008-01-16 15:55                     ` [kvm-devel] " Laurent Vivier
2008-01-16 11:51 ` [Qemu-devel] [RFC][PATCH] Modify loop device to be able to managepartitions " Sergey Bychkov
2008-01-16 12:51   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080115182745.GY17783@redhat.com \
    --to=berrange-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=Laurent.Vivier-6ktuUTfB/bM@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.