From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Dave Young <hidave.darkstar@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: 2.6.24-rc7 lockdep warning when poweroff
Date: Wed, 16 Jan 2008 09:11:56 +0100 [thread overview]
Message-ID: <20080116081155.GA10019@elte.hu> (raw)
In-Reply-To: <1200401245.26045.19.camel@twins>
* Peter Zijlstra <peterz@infradead.org> wrote:
> > > The patch looks ok, one important thing to note is that it means
> > > that all workqueues instantiated by the same __create_workqueue()
> > > call-site share lock dependency chains - I'm unsure if that might
> > > get us into trouble or not.
> >
> > It doesn't seem to have so far ;) I don't think it should. If some
> > code allocates a per-instance workqueue that's much like having an
> > inode lock or so.
>
> We had to split up the inode lock to per filesystem classes, just
> because the lock chains were conflicting between them...
i.e. filesystems can legally have different locking rules wrt. i_lock. I
dont really like it (we should have as simple locking rules as possible)
but it is the VFS status quo :)
Ingo
next prev parent reply other threads:[~2008-01-16 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 9:04 2.6.24-rc7 lockdep warning when poweroff Dave Young
2008-01-14 9:24 ` Peter Zijlstra
2008-01-14 10:35 ` Johannes Berg
2008-01-14 10:41 ` Peter Zijlstra
2008-01-14 10:51 ` Johannes Berg
2008-01-15 0:31 ` Dave Young
2008-01-15 1:24 ` Dave Young
2008-01-15 8:42 ` Peter Zijlstra
2008-01-15 10:41 ` Johannes Berg
2008-01-15 12:21 ` Peter Zijlstra
2008-01-15 12:39 ` Johannes Berg
2008-01-15 12:47 ` Peter Zijlstra
2008-01-15 13:04 ` [PATCH for 2.6.24] fix workqueue creation API lockdep interaction Johannes Berg
2008-01-16 4:41 ` Dave Young
2008-01-16 8:11 ` Ingo Molnar [this message]
2008-01-15 23:54 ` 2.6.24-rc7 lockdep warning when poweroff Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116081155.GA10019@elte.hu \
--to=mingo@elte.hu \
--cc=hidave.darkstar@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.