From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: John Levon <levon@movementarian.org>
Cc: tgingold@free.fr, Xen-devel <xen-devel@lists.xensource.com>
Subject: Re: PATCH [xenconsoled]: makes pty slave raw early
Date: Wed, 16 Jan 2008 11:06:17 +0000 [thread overview]
Message-ID: <20080116110617.GF4261@implementation.uk.xensource.com> (raw)
In-Reply-To: <20080116105853.GA26724@totally.trollied.org.uk>
John Levon, le Wed 16 Jan 2008 10:58:53 +0000, a écrit :
> On Wed, Jan 16, 2008 at 06:30:04AM +0100, tgingold@free.fr wrote:
>
> > diff -r ca2828a46217 -r 0353ead264ba tools/console/daemon/io.c
> > --- a/tools/console/daemon/io.c Wed Jan 16 06:21:50 2008 +0100
> > +++ b/tools/console/daemon/io.c Wed Jan 16 06:25:43 2008 +0100
> > @@ -278,8 +278,10 @@ static int openpty(int *amaster, int *as
> > if (winp)
> > ioctl(sfd, TIOCSWINSZ, winp);
> >
> > + if (termp)
> > + tcsetattr(sfd, TCSAFLUSH, termp);
> > +
>
> This is wrong. openpty() only retrieves term settings, not sets it.
Please re-read manpages:
« If termp is not NULL, the terminal parameters of the slave will be
set to the values in termp. »
And in glibc the termp structure recently got const.
Samuel
next prev parent reply other threads:[~2008-01-16 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 5:30 PATCH [xenconsoled]: makes pty slave raw early tgingold
2008-01-16 10:57 ` Samuel Thibault
2008-01-16 12:20 ` John Levon
2008-01-16 13:20 ` Keir Fraser
2008-01-16 13:24 ` Samuel Thibault
2008-01-16 14:04 ` tgingold
2008-01-16 10:58 ` John Levon
2008-01-16 11:06 ` Samuel Thibault [this message]
2008-01-16 11:10 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116110617.GF4261@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=levon@movementarian.org \
--cc=tgingold@free.fr \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.