From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] disable lomount and miniterm by default Date: Wed, 16 Jan 2008 17:11:31 +0000 Message-ID: <20080116171131.GC27604@redhat.com> References: <18318.14444.387687.996933@mariner.uk.xensource.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <18318.14444.387687.996933@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Jan 16, 2008 at 05:01:32PM +0000, Ian Jackson wrote: Content-Description: message body text > lomount is a tool which reads and parses a partition table in a disk > image block device and then uses mount -o ...offset=... to mount it. > This is not an ideal approach. For example, if the intended > filesystem has corrupted metadata the kernel's filesystem driver may > start to write outside of the intended region. This might even be > exploitable in some perverse circumstances. > > Nowadays people wanting to do this should use kpartx, which uses > devmapper to create appropriate range mappings. So lomount should be > disabled. +1 for this. > miniterm may well be useful but it is a clone-and-hack of an upstream > project and is currently built but not installed by default, partly > because it doesn't make sense to install on the dom0 which it might be > trying to debug. Any idea of what the changes are wrt to upstream ? If they're useful we should try and get them upstream. While on the subject of tools, I'm puzelled why Xen has created custom tools qcow-create, qcow2raw and img2qcow, when they are less functional than the existing 'qemu-img' tool that comes as part of the QEMU codebase Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|