From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1JFFh1-0006yG-D5
	for mharc-grub-devel@gnu.org; Wed, 16 Jan 2008 16:21:03 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFFgz-0006xl-5L
	for grub-devel@gnu.org; Wed, 16 Jan 2008 16:21:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFFgx-0006wl-OE
	for grub-devel@gnu.org; Wed, 16 Jan 2008 16:21:00 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFFgx-0006wa-I2
	for grub-devel@gnu.org; Wed, 16 Jan 2008 16:20:59 -0500
Received: from aybabtu.com ([69.60.117.155])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1JFFgx-0007g2-7P
	for grub-devel@gnu.org; Wed, 16 Jan 2008 16:20:59 -0500
Received: from [192.168.10.6] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <rmh@aybabtu.com>) id 1JFFgv-0007kF-9q
	for grub-devel@gnu.org; Wed, 16 Jan 2008 22:20:58 +0100
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1JFFfI-0007F5-QP
	for grub-devel@gnu.org; Wed, 16 Jan 2008 22:19:16 +0100
Date: Wed, 16 Jan 2008 22:19:16 +0100
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080116211916.GA25740@thorin>
References: <fmaua9$kp5$1@ger.gmane.org> <20080115180547.GA21853@thorin>
	<fmiv4q$vo1$3@ger.gmane.org> <20080116134002.GA26468@thorin>
	<20080116193909.GA15445@greenwood>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080116193909.GA15445@greenwood>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: Using GRUB2 with CoreBoot (formerly known as LinuxBIOS) 1/4:
	Find tables
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2008 21:21:01 -0000

On Wed, Jan 16, 2008 at 08:39:09PM +0100, Uwe Hermann wrote:
> On Wed, Jan 16, 2008 at 02:40:02PM +0100, Robert Millan wrote:
> > +  auto int check_signature (grub_linuxbios_table_header_t);
> > +  int check_signature (grub_linuxbios_table_header_t table_header)
> > +  {
> > +    if (! grub_memcmp (table_header->signature, "LBIO", 4))
> > +      return 1;
> > +
> > +    return 0;
> > +  }
> > +
> > +  /* Assuming sizeof(*table_header) alignment.  */
> 
> Maybe a more verbose comment here?
> 
> 
> > +  for (table_header = 0x500; table_header < 0x1000; table_header++)
> > +    if (check_signature (table_header))
> > +      goto signature_found;
> > +
> > +  for (table_header = 0xf0000; table_header < 0x100000; table_header++)
> > +    if (check_signature (table_header))
> > +      goto signature_found;
> > +
> > +  grub_fatal ("Could not find CoreBoot table\n");
> 
> "coreboot" please.

Fixed, thanks.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)