From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] TFTP: add host ip addr support
Date: Wed, 16 Jan 2008 23:27:54 +0100 [thread overview]
Message-ID: <20080116222754.GG31365@game.jcrosoft.org> (raw)
In-Reply-To: <20080116212624.AE252243C0@gemini.denx.de>
On 22:26 Wed 16 Jan , Wolfgang Denk wrote:
> In message <1200517000.31842.70.camel@localhost> you wrote:
> >
> > #define MAX_LEN 80
> > static char tftp_filename[MAX_LEN];
> >
> > strncpy(tftp_filename, str, MAX_LEN);
> > tftp_filename[MAX_LEN-1] = 0;
> >
> > May be truncated, but never overruns.
>
> Acked-by: wd at denx.de :-)
>
>
> Except that the length should be 128 to match the boot file name
> length that BOOTP / DHCP can pass as per RFC.
Personnaly, I'll prefer 1K length because if you use as I use a lost of
time a full path when downloading uImage or other so a path with a
length over than 512 arrive often.
And with nfs it's the same
Best Regards,
J.
next prev parent reply other threads:[~2008-01-16 22:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 23:43 [U-Boot-Users] [PATCH] TFTP: add host ip addr support Jean-Christophe PLAGNIOL-VILLARD
2008-01-15 13:50 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-16 3:19 ` Ben Warren
2008-01-16 7:19 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-16 15:49 ` Ben Warren
2008-01-16 17:33 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-16 20:27 ` Ben Warren
2008-01-16 20:40 ` Wolfgang Denk
2008-01-16 20:47 ` Ben Warren
2008-01-16 20:56 ` McMullan, Jason
2008-01-16 21:26 ` Wolfgang Denk
2008-01-16 22:27 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-01-16 23:09 ` Wolfgang Denk
2008-01-16 23:33 ` Ben Warren
2008-01-17 22:08 ` [U-Boot-Users] [PATCH 0/1] " Jean-Christophe PLAGNIOL-VILLARD
2008-01-17 22:08 ` [U-Boot-Users] [PATCH 1/1] Fix nfs command help to reflect that the serverip is optional Jean-Christophe PLAGNIOL-VILLARD
2008-01-17 22:29 ` Ben Warren
2008-01-17 22:31 ` [U-Boot-Users] [PATCH 0/1] TFTP: add host ip addr support Wolfgang Denk
2008-01-17 22:42 ` Andre Renaud
2008-01-18 0:19 ` Ben Warren
2008-01-18 0:30 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-16 21:23 ` [U-Boot-Users] [PATCH] " Wolfgang Denk
2008-01-16 21:38 ` Ben Warren
2008-01-17 23:51 ` Jean-Christophe PLAGNIOL-VILLARD
2008-01-18 0:14 ` Jean-Christophe PLAGNIOL-VILLARD
2008-02-04 23:42 ` Wolfgang Denk
2008-01-18 0:23 ` Ben Warren
-- strict thread matches above, loose matches on Subject: below --
2007-12-24 15:55 Jean-Christophe PLAGNIOL-VILLARD
2007-12-24 16:40 ` Jerry Van Baren
2007-12-26 20:42 ` Haavard Skinnemoen
2007-12-26 23:09 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116222754.GG31365@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.