From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: bbpetkov@yahoo.de
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2
Date: Wed, 16 Jan 2008 23:51:29 +0100 [thread overview]
Message-ID: <200801162351.29135.bzolnier@gmail.com> (raw)
In-Reply-To: <20080115201251.GC5699@gollum.tnic>
On Tuesday 15 January 2008, Borislav Petkov wrote:
> ... and finally the last one. Whew! I think we're done here for now. :)
>
> --
> From: Borislav Petkov <bbpetkov@yahoo.de>
> Date: Tue, 15 Jan 2008 21:01:04 +0100
> Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2
>
> such as
> ERROR: switch and case should be at the same indent
> ERROR: need spaces around that '=' (ctx:VxV)
> ERROR: trailing statements should be on next line
> WARNING: no space between function name and open parenthesis '('
> WARNING: printk() should include KERN_ facility level
> ERROR: That open brace { should be on the previous line
> ERROR: use tabs not spaces
> ERROR: do not use assignment in if condition
> WARNING: braces {} are not necessary for single statement blocks
> ERROR: need space after that ',' (ctx:VxV)
> WARNING: line over 80 characters
> ERROR: do not use assignment in if condition
> ...
> and so on.
>
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
applied
next prev parent reply other threads:[~2008-01-16 22:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 20:18 [PATCH 0/12] ide-floppy redux v2.5 Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 1/12] ide-floppy: remove struct idefloppy_mode_parameter_header Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 2/12] ide-floppy: remove struct idefloppy_flexible_disk_page Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 3/12] ide-floppy: remove struct idefloppy_capacity_descriptor Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 4/12] ide-floppy: factor out ioctl handlers from idefloppy_ioctl() Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 5/12] ide-floppy: report DMA handling in idefloppy_pc_intr() properly Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 6/12] ide-floppy: mv idefloppy_{should_,}report_error Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 7/12] ide-floppy: remove IDEFLOPPY_DEBUG_BUGS macro Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 9/12] ide-floppy: remove unused IDEFLOPPY_USE_READ12 Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 10/12] ide-floppy: remove atomic test_*bit macros Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-13 20:18 ` [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues Borislav Petkov
2008-01-13 20:18 ` Borislav Petkov
2008-01-15 20:12 ` (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2 Borislav Petkov
2008-01-16 22:51 ` Bartlomiej Zolnierkiewicz [this message]
2008-01-14 21:51 ` [PATCH 11/12] ide-floppy: remove IDEFLOPPY_DEBUG_INFO Bartlomiej Zolnierkiewicz
2008-01-14 21:50 ` [PATCH 10/12] ide-floppy: remove atomic test_*bit macros Bartlomiej Zolnierkiewicz
2008-01-14 22:32 ` Bartlomiej Zolnierkiewicz
2008-01-15 20:09 ` Borislav Petkov
2008-01-16 22:08 ` Bartlomiej Zolnierkiewicz
2008-01-15 7:07 ` Borislav Petkov
2008-01-15 20:10 ` Borislav Petkov
2008-01-16 22:25 ` Bartlomiej Zolnierkiewicz
2008-01-14 21:38 ` [PATCH 8/12] ide-floppy: merge idefloppy_{input,output}_buffers Bartlomiej Zolnierkiewicz
2008-01-15 7:14 ` Borislav Petkov
2008-01-14 21:38 ` [PATCH 0/12] ide-floppy redux v2.5 Bartlomiej Zolnierkiewicz
2008-01-20 12:38 ` Borislav Petkov
2008-01-20 12:38 ` Borislav Petkov
2008-01-21 22:45 ` Bartlomiej Zolnierkiewicz
2008-01-22 5:32 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801162351.29135.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=bbpetkov@yahoo.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.