From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: Question regarding arch/sh/cchips merger
Date: Thu, 17 Jan 2008 01:26:03 +0000 [thread overview]
Message-ID: <20080117012603.GC14107@linux-sh.org> (raw)
In-Reply-To: <20080116224540.2e2ae7e6.Kristoffer.Ericson@Gmail.com>
On Wed, Jan 16, 2008 at 10:45:40PM -0800, Kristoffer Ericson wrote:
> Would it be good to merge hd64465/hd64461 inside arch/sh/cchips? Ive
> checked the files and they are quite similiar and since the header can
> be merged they could also be easily. You mentioned the they really
> belong inside mfd but never touched that area.
>
> So in short, would such a patch be accepted?
>
Merging in arch/sh/cchips is fine for now, but it really does need to be
cleaned up to look more like a standard mfd driver, and moved in to
drivers/mfd proper. Following something like sm501 as an example of how
to do things like the IRQ demux sanely.
While I can give you suggestions on what needs to be done, I don't have
anything with those ancient cchips on it either at the office or at home,
which makes you the sole person to do the mfd work. At this point hp6xx
is the only thing using these parts, so presumably you have some sort of
testing in place that ensures that things are happy on the cchip side.
prev parent reply other threads:[~2008-01-17 1:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 21:45 Question regarding arch/sh/cchips merger Kristoffer Ericson
2008-01-17 1:26 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080117012603.GC14107@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.