All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: nested functions used by multiboot2 loader corrupt stack
Date: Thu, 17 Jan 2008 13:21:30 +0100	[thread overview]
Message-ID: <20080117122130.GB2399@thorin> (raw)
In-Reply-To: <ca0f59980801170015v10c42e4ah367c7f2172143df4@mail.gmail.com>

On Thu, Jan 17, 2008 at 04:15:23PM +0800, Bean wrote:
> 
> You need to add NESTED_FUNC_ATTR to nested callback function that use
> local variable. here is the patch:

Glad to see you found the reason!

But I don't get it.  I see that:

#define NESTED_FUNC_ATTR __attribute__ ((__regparm__ (2)))

so does this mean in one of the calls the caller and callee disagreed about
how the third param is passed?

Also, we have a lot of nested functions without this macro.  How does one
distinguish the ones that need it from the ones that don't?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2008-01-17 12:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 23:05 nested functions used by multiboot2 loader corrupt stack Robert Millan
2008-01-17  8:15 ` Bean
2008-01-17 12:21   ` Robert Millan [this message]
2008-01-17 15:47     ` Bean
2008-01-20 23:47       ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080117122130.GB2399@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.