From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 5/5] ACPI: add DMI to enable OSI(Linux) on ThinkPad T61
Date: Thu, 17 Jan 2008 12:28:32 +0000 [thread overview]
Message-ID: <20080117122832.GB32133@srcf.ucam.org> (raw)
In-Reply-To: <0bf08de2227cabeb40a6ea72b3fa188a2e325335.1200565331.git.len.brown@intel.com>
On Thu, Jan 17, 2008 at 05:24:50AM -0500, Len Brown wrote:
> + {
> + .callback = dmi_enable_osi_linux,
> + .ident = "Lenovo ThinkPad T61",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T61"),
> + },
> + },
> +
If we add it for specific devices, aren't vendors going to assume that
future versions of that device will also be able to rely on this
behaviour? I'm very reluctant to add whitelisting - I suspect it makes
more sense for us to just be compatible with Windows. My experiments
with the T61 suggested that it was possible to get everything working
without this, but I'll need to go back and check what the behaviour
actually was to be sure.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-01-17 12:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 10:24 [PATCH 0/5] improved knobs to deal with OSI(Linux) Len Brown
2008-01-17 10:24 ` [PATCH 1/5] DMI: move dmi_available declaration to linux/dmi.h Len Brown
2008-01-17 10:24 ` [PATCH 2/5] DMI: create dmi_dump_entries() Len Brown
2008-01-17 10:24 ` [PATCH 3/5] ACPI: use dmi_dump_entries() instead of requesting dmidecode output Len Brown
2008-01-17 10:24 ` [PATCH 4/5] ACPI: OSI(Linux) cmdline and DMI BIOS workarounds Len Brown
2008-01-17 10:24 ` [PATCH 5/5] ACPI: add DMI to enable OSI(Linux) on ThinkPad T61 Len Brown
2008-01-17 12:28 ` Matthew Garrett [this message]
2008-01-17 14:46 ` Henrique de Moraes Holschuh
2008-01-17 20:04 ` Len Brown
2008-01-17 21:31 ` Theodore Tso
2008-01-19 7:40 ` Len Brown
2008-01-19 12:08 ` Henrique de Moraes Holschuh
2008-01-19 14:17 ` Theodore Tso
2008-01-19 15:33 ` Henrique de Moraes Holschuh
2008-01-19 15:43 ` Matthew Garrett
2008-01-19 23:19 ` Theodore Tso
2008-01-20 4:13 ` Len Brown
2008-01-20 11:16 ` Rafael J. Wysocki
2008-01-20 12:03 ` Tomas Carnecky
2008-01-20 18:31 ` Len Brown
2008-01-20 19:21 ` Tomas Carnecky
2008-01-21 1:52 ` Theodore Tso
2008-01-21 9:50 ` Matthew Garrett
2008-01-21 19:00 ` Theodore Tso
2008-01-21 19:37 ` Matthew Garrett
2008-01-22 5:37 ` Len Brown
2008-01-20 19:49 ` Henrique de Moraes Holschuh
2008-02-18 16:58 ` Thomas Renninger
2008-02-18 19:17 ` Henrique de Moraes Holschuh
2008-02-19 0:00 ` Thomas Renninger
2008-02-19 0:26 ` Theodore Tso
2008-02-19 6:34 ` Thomas Renninger
2008-02-19 13:24 ` Henrique de Moraes Holschuh
2008-02-19 10:26 ` Thomas Renninger
2008-02-19 14:24 ` Henrique de Moraes Holschuh
2008-02-20 1:43 ` Thomas Renninger
2008-02-20 2:47 ` Henrique de Moraes Holschuh
2008-01-19 7:50 ` [PATCH 6/5] ACPI: DMI blacklist for OSI(Linux) Len Brown
2008-01-19 8:16 ` Andi Kleen
2008-01-20 4:18 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080117122832.GB32133@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.