From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JFUhK-0003aH-6x
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 08:22:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JFUhF-0003ZX-N3
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 08:22:21 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JFUhF-0003ZU-HS
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 08:22:17 -0500
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1JFUhE-0006Ij-6U
	for qemu-devel@nongnu.org; Thu, 17 Jan 2008 08:22:16 -0500
Date: Thu, 17 Jan 2008 13:22:53 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH 2/5] Add a PowerPC branch detector
Message-ID: <20080117132253.GE9767@networkno.de>
References: <478EF8E3.2050503@csgraf.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <478EF8E3.2050503@csgraf.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <alex@csgraf.de>
Cc: qemu-devel@nongnu.org

Alexander Graf wrote:
> PowerPCs have static instruction lengths, so writing an "in-between" brl
> detection is quite simple on this architecture. You are welcome to write
> something like this for any other platform, but if a compile doesn't
> trigger build errors on PowerPC, it shouldn't on other platforms either,
> as PowerPC has quite advanced branch instructions.
> 
> This patch is not mandatory, makes debugging a lot easier though.

> Index: qemu-snapshot-2008-01-15_05/dyngen.c
> ===================================================================
> --- qemu-snapshot-2008-01-15_05.orig/dyngen.c
> +++ qemu-snapshot-2008-01-15_05/dyngen.c
> @@ -1488,6 +1488,16 @@ void gen_code(const char *name, host_ulo
>          if (get32((uint32_t *)p) != 0x4e800020)
>              error("blr expected at the end of %s", name);
>          copy_size = p - p_start;
> +
> +/* blr check for inline returns */
> +
> +        if(strstart(name, "op_", NULL) && !strstart(name, "op_exit", NULL)) {
> +            for(p=p_start; p < p_end - 4; p+=4) {
> +                if ((get32((uint32_t *)p) & 0xfc00fff0) == 0x4c000020) {
> +                    error("Inline blr detected in %s. Please append FORCE_RET to the function.", name);
> +                }
> +            }
> +        }

Is check_ops.sh not enough for debugging micro-ops?


Thiemo