From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] [NFSD] Typo in nfsd_vers()
Date: Thu, 17 Jan 2008 09:33:42 -0500 [thread overview]
Message-ID: <20080117143341.GA16581@fieldses.org> (raw)
In-Reply-To: <478F472F.9050800-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
On Thu, Jan 17, 2008 at 07:16:47AM -0500, Steve Dickson wrote:
> During my travels I found a small typo in nfsd_vers() (the routine
> used by rpc.nfsd to set the protocol version(s) in NFS server)
>
> When testing to see which versions are available, nfsd_vers() should
> use nfsd_versions[] not nfsd_version[]. The reason this typo is
> not noticeable is due to the fact this availability info is used in
> a reply that rpc.nfsd ignores.
Thanks, applied!
Your mailer's messing up the whitespace, though--might want to fix that
for next time.
--b.
>
> steved.
>
>
> Author: Steve Dickson <steved@redhat.com>
> Date: Thu Jan 17 06:50:57 2008 -0500
>
> In nfsd_vers() the NFSD_AVAIL command should be using nfsd_versions[]
> not nfsd_version[]
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 1190aea..f0c66e0 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -134,7 +134,7 @@ int nfsd_vers(int vers, enum vers_op change)
> case NFSD_TEST:
> return nfsd_versions[vers] != NULL;
> case NFSD_AVAIL:
> - return nfsd_version[vers] != NULL;
> + return nfsd_versions[vers] != NULL;
> }
> return 0;
> }
next prev parent reply other threads:[~2008-01-17 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 12:16 [PATCH] [NFSD] Typo in nfsd_vers() Steve Dickson
[not found] ` <478F472F.9050800-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-01-17 14:33 ` J. Bruce Fields [this message]
2008-01-17 23:10 ` Jeff Layton
[not found] ` <20080117181055.2bd53d7d-PC62bkCOHzGdMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2008-01-18 22:06 ` J. Bruce Fields
2008-01-18 22:10 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080117143341.GA16581@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.