All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: RE: [PATCH] example and default IP addresses
Date: Thu, 17 Jan 2008 18:52:39 -0700	[thread overview]
Message-ID: <20080117185239937.00000001968@djm-pc> (raw)
In-Reply-To: <18319.30118.645434.899532@mariner.uk.xensource.com>

Hi Keir --

Per the below discussion, could you revert the change to network-nat
in the new cset 16739?

Thanks,
Dan

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com
> [mailto:xen-devel-bounces@lists.xensource.com]On Behalf Of Ian Jackson
> Sent: Thursday, January 17, 2008 8:35 AM
> To: dan.magenheimer@oracle.com
> Cc: xen-devel@lists.xensource.com
> Subject: RE: [Xen-devel] [PATCH] example and default IP addresses
> 
> 
> Dan Magenheimer writes ("RE: [Xen-devel] [PATCH] example and 
> default IP addresses"):
> > In the patch to network-nat, I see that you are replacing 
> the 10.0.0.0/16
> > usage with 192.0.2.0/24.  Actually, vif-nat has a dependency on it
> > being 10.0.0.0/8(!), at least if more than 256 domains are 
> launched (not
> > necessarily simultaneously, just sequentially created and 
> destroyed).
> > In vif-nat ip_from_dom, IP's are created as 10.x.y.z for 
> vifw.z, where
> > x*256+y==w.
> 
> Firstly, I think it's important to note that network-nat and vif-nat
> are pretty ropey.  Anyone who is using them will almost certainly have
> had to adjust them to local conditions anyway.  For example, these
> scripts attempt to find and edit your local dhcp server configuration
> file !
> 
> > I'm not sure what the right answer is, but 192.0.2.0/24 definitely
> > doesn't have enough bits.  And regardless of the answer, 
> vif-nat will
> > need to be patched also.
> 
> Having said that, I think you're right.  vif-nat does indeed have to
> use 10/8 for static hosts for the reason you give.  Although really I
> think this is a poor approach.  So my change to network-nat ought not
> to be applied.
> 
> In practice many people using this code in any real setting are likely
> to fall foul of address clashes anyway as it's very likely that they
> have at least some use of 10/8 ...
> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>

      parent reply	other threads:[~2008-01-18  1:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 15:12 [PATCH] example and default IP addresses Ian Jackson
2008-01-16 17:53 ` Dan Magenheimer
2008-01-17 15:35   ` Ian Jackson
2008-01-17 16:03     ` Daniel P. Berrange
2008-01-18  3:27       ` Dan Magenheimer
2008-01-18  3:53         ` Daniel P. Berrange
2008-01-18  1:52     ` Dan Magenheimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080117185239937.00000001968@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.