All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Sam Ravnborg <sam@ravnborg.org>,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6.24 patch] x86: allow 64bit setting in Kconfig
Date: Thu, 17 Jan 2008 23:43:01 +0200	[thread overview]
Message-ID: <20080117214301.GA28233@does.not.exist> (raw)

Recently someone told me he had a bug on x86 and to reproduce
it I should "'make allyesconfig' and disable CONFIG_HOTPLUG=y".

But I didn't see it.

"make allyesconfig" is ambiguous on x86 and he had a 64bit computer.

There go another two hours compile time.

It makes sense to have the Kconfig default and the defconfig based on 
whether you are on a 32bit or a 64bit machine, but it's complete 
nonsense to not offer the Kconfig variable unless you had explicitely 
given ARCH=x86 (in which case you could as well immediately set the ARCH 
to i386 or x86_64).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
fcf848366a166812fa32b2a22f2631fcd4982cb4 
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 80b7ba4..0e6e74d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -3,7 +3,7 @@ mainmenu "Linux Kernel Configuration for x86"
 
 # Select 32 or 64 bit
 config 64BIT
-	bool "64-bit kernel" if ARCH = "x86"
+	bool "64-bit kernel"
 	default ARCH = "x86_64"
 	help
 	  Say yes to build a 64-bit kernel - formerly known as x86_64


             reply	other threads:[~2008-01-17 21:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 21:43 Adrian Bunk [this message]
2008-01-18 10:44 ` [2.6.24 patch] x86: allow 64bit setting in Kconfig Ingo Molnar
2008-01-18 10:50   ` Harvey Harrison
2008-01-18 11:37     ` Sam Ravnborg
2008-01-18 12:02       ` Ingo Molnar
2008-01-18 12:09         ` Adrian Bunk
2008-01-18 11:48     ` Ingo Molnar
2008-01-18 17:00   ` Ingo Molnar
2008-01-18 17:26     ` Adrian Bunk
2008-01-18 21:06       ` Ingo Molnar
2008-01-18 21:23         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080117214301.GA28233@does.not.exist \
    --to=bunk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.