All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	Tomas Winkler <tomasw@gmail.com>,
	Tomas Carnecky <tom@dbservice.com>,
	ipw3945-devel@lists.sourceforge.net,
	linux-wireless@vger.kernel.org
Subject: Re: led support in mac80211 and drivers
Date: Thu, 17 Jan 2008 23:12:59 +0100	[thread overview]
Message-ID: <200801172313.00246.mb@bu3sch.de> (raw)
In-Reply-To: <1200584782.8007.59.camel@johannes.berg>

On Thursday 17 January 2008 16:46:22 Johannes Berg wrote:
> > > > > Actually the major problem I have currently with mac80211 trigger
> > > > > implementation RX/TX trigger since Intel's led doesn't have to be
> > > > > triggered ON/OFF on each packet, led is capable of blinking itself.,
> 
> I'm wondering if this shouldn't simply be a driver decision and mac80211
> exports an RXon LED that is always "on" for as long as receive is
> running (whatever that means, please specify!)

I read this thread multiple times, but I don't get where the problem is.
Why don't you simply implement this in the driver:
When LED didn't change software state for X jiffies, switch the auto-blinking
LED in the hardware off. Switch it on if it's off in hardware and there's
a software state transition.
Where's the problem? This is trivial to implement.

-- 
Greetings Michael.

  parent reply	other threads:[~2008-01-17 22:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <478DF297.9020904@dbservice.com>
     [not found] ` <1ba2fa240801160832g611d5763gcb3d681353019d4f@mail.gmail.com>
     [not found]   ` <478E465A.2030003@dbservice.com>
     [not found]     ` <1ba2fa240801161038t235f9ae4m3b1f7e1963b592ef@mail.gmail.com>
2008-01-16 20:01       ` led support in mac80211 and drivers John W. Linville
2008-01-16 21:34         ` Tomas Winkler
2008-01-17  1:04         ` Tomas Carnecky
2008-01-17 15:46         ` Johannes Berg
2008-01-17 16:40           ` Tomas Winkler
2008-01-18  1:01             ` Johannes Berg
2008-01-17 22:12           ` Michael Buesch [this message]
2008-01-17 23:14             ` Johannes Berg
2008-01-18  0:35             ` Tomas Winkler
2008-01-18  3:56               ` [ipw3945-devel] " Jerone Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801172313.00246.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tom@dbservice.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.