All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Ingo Molnar <mingo@elte.hu>
Cc: venkatesh.pallipadi@intel.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT
Date: Fri, 18 Jan 2008 01:03:37 -0800	[thread overview]
Message-ID: <200801180103.37771.yinghai.lu@sun.com> (raw)
In-Reply-To: <20080118081040.GB16597@elte.hu>

On Friday 18 January 2008 12:10:40 am Ingo Molnar wrote:
> 
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> 
> >  config MTRR
> >  	bool "MTRR (Memory Type Range Register) support"
> > -	depends on !PAT
> > +	depends on !X86_PAT
> >  	---help---
> >  	  On Intel P6 family processors (Pentium Pro, Pentium II and later)
> >  	  the Memory Type Range Registers (MTRRs) may be used to control
> 
> thanks. But, i think we should rather do the following: if X86_PAT is 
> eanbled then /proc/mtrr should be read-only. There's no problem 
> _looking_ at MTRR contents, as long as we do not try to modify them. Hm?

anyway 

depends on !PAT

need to be removed.

it seems when PAT is used, some code still touch MTRR.

YH

  reply	other threads:[~2008-01-18  9:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  3:50 [PATCH] X86: fix typo PAT to X86_PAT Yinghai Lu
2008-01-18  8:10 ` Ingo Molnar
2008-01-18  9:03   ` Yinghai Lu [this message]
2008-01-18 12:31     ` Ingo Molnar
2008-01-18 18:24       ` Dave Jones
2008-01-18 18:47         ` Pallipadi, Venkatesh
2008-01-18 18:56           ` Dave Jones
2008-01-18 21:03           ` Ingo Molnar
2008-01-18 21:02         ` Ingo Molnar
2008-01-19  3:28           ` Dave Jones
2008-01-19  7:56             ` [PATCH] X86: disable X86_PAT really Yinghai Lu
2008-01-19  7:58             ` [PATCH] X86: fix typo PAT to X86_PAT Yinghai Lu
2008-01-22 18:26             ` Pallipadi, Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801180103.37771.yinghai.lu@sun.com \
    --to=yinghai.lu@sun.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.