From: David Chinner <dgc@sgi.com>
To: Valerie Henson <val@vahconsulting.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger@clusterfs.com>, Ric Wheeler <ric@emc.com>
Subject: Re: [RFC] Parallelize IO for e2fsck
Date: Fri, 18 Jan 2008 12:15:42 +1100 [thread overview]
Message-ID: <20080118011542.GQ155259@sgi.com> (raw)
In-Reply-To: <70b6f0bf0801161330y46ec555m5d4994a1eea7d045@mail.gmail.com>
On Wed, Jan 16, 2008 at 01:30:43PM -0800, Valerie Henson wrote:
> Hi y'all,
>
> This is a request for comments on the rewrite of the e2fsck IO
> parallelization patches I sent out a few months ago. The mechanism is
> totally different. Previously IO was parallelized by issuing IOs from
> multiple threads; now a single thread issues fadvise(WILLNEED) and
> then uses read() to complete the IO.
Interesting.
We ultimately rejected a similar patch to xfs_repair (pre-population
the kernel block device cache) mainly because of low memory
performance issues and it doesn't really enable you to do anything
particularly smart with optimising I/O patterns for larger, high
performance RAID arrays.
The low memory problems were particularly bad; the readahead
thrashing cause a slowdown of 2-3x compared to the baseline and
often it was due to the repair process requiring all of memory
to cache stuff it would need later. IIRC, multi-terabyte ext3
filesystems have similar memory usage problems to XFS, so there's
a good chance that this patch will see the same sorts of issues.
> Single disk performance doesn't change, but elapsed time drops by
> about 50% on a big RAID-5 box. Passes 1 and 2 are parallelized. Pass
> 5 is left as an exercise for the reader.
Promising results, though....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-01-18 1:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <70b6f0bf0801161322k2740a8dch6a0d6e6e112cd2d0@mail.gmail.com>
2008-01-16 21:30 ` [RFC] Parallelize IO for e2fsck Valerie Henson
2008-01-18 1:15 ` David Chinner [this message]
2008-01-18 1:43 ` Valerie Henson
2008-01-21 23:00 ` Andreas Dilger
2008-01-22 3:38 ` David Chinner
2008-01-22 3:38 ` David Chinner
2008-01-22 4:17 ` Valdis.Kletnieks
2008-01-22 7:00 ` Andreas Dilger
2008-01-22 13:05 ` Alan Cox
2008-01-22 14:40 ` Theodore Tso
2008-01-22 14:57 ` Arnaldo Carvalho de Melo
2008-01-28 19:30 ` Pavel Machek
2008-01-28 19:56 ` Theodore Tso
2008-01-28 20:01 ` Pavel Machek
2008-02-03 13:51 ` KOSAKI Motohiro
2008-01-29 8:29 ` david
2008-01-22 7:05 ` Andreas Dilger
2008-01-22 8:16 ` David Chinner
2008-01-22 8:16 ` David Chinner
2008-01-22 17:42 ` Bryan Henderson
[not found] <9Mo9w-7Ws-25@gated-at.bofh.it>
[not found] ` <9Mo9w-7Ws-23@gated-at.bofh.it>
[not found] ` <9OdWm-7uN-25@gated-at.bofh.it>
[not found] ` <9Oi9A-5EJ-3@gated-at.bofh.it>
[not found] ` <9OiMg-6IC-1@gated-at.bofh.it>
[not found] ` <9OlqL-2xG-3@gated-at.bofh.it>
[not found] ` <9Orda-3ub-45@gated-at.bofh.it>
2008-01-24 17:32 ` Bodo Eggert
2008-01-24 17:32 ` Bodo Eggert
2008-01-24 17:32 ` Bodo Eggert
2008-01-24 22:07 ` Andreas Dilger
2008-01-24 23:08 ` Adrian Bunk
2008-01-24 23:40 ` Theodore Tso
2008-01-25 0:25 ` Zan Lynx
2008-01-25 11:09 ` Andreas Dilger
2008-01-26 0:55 ` Zan Lynx
2008-01-26 11:56 ` KOSAKI Motohiro
2008-01-25 18:03 ` Bryan Henderson
2008-01-25 23:01 ` Bodo Eggert
2008-01-26 1:55 ` Bryan Henderson
2008-01-26 13:21 ` Theodore Tso
2008-01-26 12:32 ` KOSAKI Motohiro
2008-01-26 12:32 ` KOSAKI Motohiro
2008-01-26 12:32 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118011542.GQ155259@sgi.com \
--to=dgc@sgi.com \
--cc=adilger@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ric@emc.com \
--cc=tytso@mit.edu \
--cc=val@vahconsulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.