From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JFgqF-0003wj-Ca for user-mode-linux-devel@lists.sourceforge.net; Thu, 17 Jan 2008 18:20:23 -0800 Received: from saraswathi.solana.com ([198.99.130.12]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1JFgqC-0001vo-ID for user-mode-linux-devel@lists.sourceforge.net; Thu, 17 Jan 2008 18:20:21 -0800 Date: Thu, 17 Jan 2008 21:19:08 -0500 From: Jeff Dike Message-ID: <20080118021908.GA10658@c2.user-mode-linux.org> References: <20080117105606.ff89e9e9.akpm@linux-foundation.org> <924EFEDD5F540B4284297C4DC59F3DEE5E90DF@orsmsx423.amr.corp.intel.com> <20080117211437.GA7573@c2.user-mode-linux.org> <20080117214150.GA25872@linux-os.sc.intel.com> <20080117230802.GA9360@c2.user-mode-linux.org> <924EFEDD5F540B4284297C4DC59F3DEE62B45A@orsmsx423.amr.corp.intel.com> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <924EFEDD5F540B4284297C4DC59F3DEE62B45A@orsmsx423.amr.corp.intel.com> Subject: Re: [uml-devel] [-mm Patch] uml: fix a building error List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: "Pallipadi, Venkatesh" Cc: user-mode-linux-devel@lists.sourceforge.net, Ingo Molnar , linux-kernel@vger.kernel.org, Mariusz Kozlowski , Thomas Gleixner , sparclinux@vger.kernel.org, WANG Cong , Andrew Morton , David Miller On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote: > >#define X X > > > >is a no-op, yes? > > > > Later there is code in generic.h which is doing > #ifndef ioremap_wc > #define ioremap_wc ioremap_nocache > #endif Ah, that makes a bit more sense. It'd be nice if there was less of a WTF factor there, though. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Dike Date: Fri, 18 Jan 2008 02:19:08 +0000 Subject: Re: [-mm Patch] uml: fix a building error Message-Id: <20080118021908.GA10658@c2.user-mode-linux.org> List-Id: References: <20080117105606.ff89e9e9.akpm@linux-foundation.org> <924EFEDD5F540B4284297C4DC59F3DEE5E90DF@orsmsx423.amr.corp.intel.com> <20080117211437.GA7573@c2.user-mode-linux.org> <20080117214150.GA25872@linux-os.sc.intel.com> <20080117230802.GA9360@c2.user-mode-linux.org> <924EFEDD5F540B4284297C4DC59F3DEE62B45A@orsmsx423.amr.corp.intel.com> In-Reply-To: <924EFEDD5F540B4284297C4DC59F3DEE62B45A@orsmsx423.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Pallipadi, Venkatesh" Cc: Andrew Morton , Mariusz Kozlowski , WANG Cong , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, David Miller , sparclinux@vger.kernel.org, Ingo Molnar , Thomas Gleixner On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote: > >#define X X > > > >is a no-op, yes? > > > > Later there is code in generic.h which is doing > #ifndef ioremap_wc > #define ioremap_wc ioremap_nocache > #endif Ah, that makes a bit more sense. It'd be nice if there was less of a WTF factor there, though. Jeff -- Work email - jdike at linux dot intel dot com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761232AbYARCUk (ORCPT ); Thu, 17 Jan 2008 21:20:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757750AbYARCUb (ORCPT ); Thu, 17 Jan 2008 21:20:31 -0500 Received: from saraswathi.solana.com ([198.99.130.12]:46184 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753220AbYARCU3 (ORCPT ); Thu, 17 Jan 2008 21:20:29 -0500 Date: Thu, 17 Jan 2008 21:19:08 -0500 From: Jeff Dike To: "Pallipadi, Venkatesh" Cc: Andrew Morton , Mariusz Kozlowski , WANG Cong , linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, David Miller , sparclinux@vger.kernel.org, Ingo Molnar , Thomas Gleixner Subject: Re: [-mm Patch] uml: fix a building error Message-ID: <20080118021908.GA10658@c2.user-mode-linux.org> References: <20080117105606.ff89e9e9.akpm@linux-foundation.org> <924EFEDD5F540B4284297C4DC59F3DEE5E90DF@orsmsx423.amr.corp.intel.com> <20080117211437.GA7573@c2.user-mode-linux.org> <20080117214150.GA25872@linux-os.sc.intel.com> <20080117230802.GA9360@c2.user-mode-linux.org> <924EFEDD5F540B4284297C4DC59F3DEE62B45A@orsmsx423.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <924EFEDD5F540B4284297C4DC59F3DEE62B45A@orsmsx423.amr.corp.intel.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote: > >#define X X > > > >is a no-op, yes? > > > > Later there is code in generic.h which is doing > #ifndef ioremap_wc > #define ioremap_wc ioremap_nocache > #endif Ah, that makes a bit more sense. It'd be nice if there was less of a WTF factor there, though. Jeff -- Work email - jdike at linux dot intel dot com