From: Kyle McMartin <kyle@mcmartin.ca>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>,
akpm@linux-foundation.org, airlied@linux.ie,
linux-kernel@vger.kernel.org
Subject: Re: [mm patch] i915: fix invalid opcode exception on cpus without clflush
Date: Thu, 17 Jan 2008 21:31:10 -0500 [thread overview]
Message-ID: <20080118023110.GA31386@phobos.i.cabal.ca> (raw)
In-Reply-To: <479008E5.1070706@zytor.com>
On Thu, Jan 17, 2008 at 09:03:17PM -0500, H. Peter Anvin wrote:
> The #ifdef is bogus. If it's required, it should go into
> asm-x86/required_features.h and then cpu_has_clflush is static; otherwise
> it's just plain wrong.
>
I have no objection to making cpu_has_clflush constant on x86_64. The
point was to get rid of a needless test & branch on 64-bit, and making
it constant will have the same effect.
cheers, Kyle
prev parent reply other threads:[~2008-01-18 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 23:52 [mm patch] i915: fix invalid opcode exception on cpus without clflush Kyle McMartin
2008-01-18 2:03 ` H. Peter Anvin
2008-01-18 2:24 ` Harvey Harrison
2008-01-18 2:31 ` Kyle McMartin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118023110.GA31386@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.