From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Fri, 18 Jan 2008 02:55:22 +0000 Subject: Re: [PATCH] Add support for SDK7780 board Message-Id: <20080118025522.GC14945@linux-sh.org> List-Id: References: <478F7921.4090203@mpc-data.co.uk> In-Reply-To: <478F7921.4090203@mpc-data.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Fri, Jan 18, 2008 at 11:19:22AM +0900, Magnus Damm wrote: > On Jan 18, 2008 12:49 AM, Nicholas Beck wrote: > > Add support for Renesas Technology Europe SDK7780 board. > > Great, thank you for your patch! > > > Signed-off-by: Nicholas Beck > > --- > > diff -urN -x '.git*' a/arch/sh/boards/renesas/sdk7780/irq.c > > b/arch/sh/boards/renesas/sdk7780/irq.c > > --- a/arch/sh/boards/renesas/sdk7780/irq.c 1970-01-01 > > 01:00:00.000000000 +0100 > > +++ b/arch/sh/boards/renesas/sdk7780/irq.c 2008-01-17 > > 15:11:09.000000000 +0000 > > @@ -0,0 +1,102 @@ > > +/* > > + * linux/arch/sh/boards/renesas/sdk7780/irq.c > > + * > > + * Renesas Technology Europe SDK7780 Support. > > + * > > + * Copyright (C) 2008 Nicholas Beck > > + * > > + * Based on linux/arch/sh/boards/renesas/r7780rp/irq.c > > This must be based on a not-so-recent kernel version. Newer kernels > use intc tables for both cpu specific and board specific irq setup. > Please consider updating the interrupt code - have a look at r7780mp > or r2d for good examples. > Indeed. Also the IRQ 14 handling looks pretty suspicious. It looks like you want to have a secondary handler for this that just sets itself up as a chained handler, as it obviously has differing semantics from the rest of the vectors.