From: Kyle McMartin <kyle@mcmartin.ca>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH] x86_64: remove redundant cpu_has_ definitions
Date: Fri, 18 Jan 2008 00:25:22 -0500 [thread overview]
Message-ID: <20080118052522.GA1726@phobos.i.cabal.ca> (raw)
In-Reply-To: <47903376.9050204@zytor.com>
On Fri, Jan 18, 2008 at 12:04:54AM -0500, H. Peter Anvin wrote:
> Unnecessary. These overrides are only needed for the anticases (known to
> be zero) or for some special hacks.
>
Cool, guess that means a bunch of them can go...
> Stuff that have proper CPUID bits get these defined as constants via the
> REQUIRED_MASK macros.
>
PSE, PGE, XMM, XMM2, and FXSR are defined as required features, and
will be optimized to a constant at compile time. Remove their redundant
definitions.
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
--- a/include/asm-x86/cpufeature.h
+++ b/include/asm-x86/cpufeature.h
@@ -195,21 +195,6 @@
#undef cpu_has_centaur_mcr
#define cpu_has_centaur_mcr 0
-#undef cpu_has_pse
-#define cpu_has_pse 1
-
-#undef cpu_has_pge
-#define cpu_has_pge 1
-
-#undef cpu_has_xmm
-#define cpu_has_xmm 1
-
-#undef cpu_has_xmm2
-#define cpu_has_xmm2 1
-
-#undef cpu_has_fxsr
-#define cpu_has_fxsr 1
-
#endif /* CONFIG_X86_64 */
#endif /* _ASM_X86_CPUFEATURE_H */
next prev parent reply other threads:[~2008-01-18 5:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 4:59 [PATCH] x86: make clflush a required feature on x86_64 Kyle McMartin
2008-01-18 5:04 ` H. Peter Anvin
2008-01-18 5:25 ` Kyle McMartin [this message]
2008-01-18 8:07 ` [PATCH] x86_64: remove redundant cpu_has_ definitions Ingo Molnar
2008-01-18 5:53 ` [PATCH] x86: make clflush a required feature on x86_64 Andi Kleen
2008-01-18 6:01 ` Kyle McMartin
2008-01-18 6:27 ` H. Peter Anvin
2008-01-11 18:16 ` Pavel Machek
2008-01-18 6:54 ` Andi Kleen
2008-01-18 13:56 ` H. Peter Anvin
2008-01-18 14:18 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118052522.GA1726@phobos.i.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.