All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: linux-kernel@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Wright <chrisw@sous-sol.org>,
	David Howells <dhowells@redhat.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] Remove vfs_init_caches_early()
Date: Fri, 18 Jan 2008 12:15:19 +1100	[thread overview]
Message-ID: <200801181215.20491.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200801181041.22157.rusty@rustcorp.com.au>

On Friday 18 January 2008 10:41:21 Rusty Russell wrote:
> vfs_init_caches_early() does nothing on IA-64 and x86-64 (unless you
> turn off CONFIG_NUMA): hashdist is set by default on these platforms.
>
> Maybe some obscure feature which requires VFS to be set up v. early
> (hence is broken in this configuration), or something arch-specific
> (which seems unlikely).  Most likely this is a relic.
>
> Unless someone has inside knowledge, the easiest way to find out is to
> rip it out and see if anyone screams.  Boots fine on my 32-bit x86 box
> here.

Ok, Chris Wright pointed me to the justification: it was because on 64G 
powerpc machines, MAX_ORDER of 11 was too small to allocate sufficient 
hashes.

See 
http://git.kernel.org/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=commitdiff;h=50c2cb5183e4f101f923212e39a58a66a530cf77

Since MAX_ORDER is now 13 on powerpc, I think we're good.

Thanks Cdub!
Rusty.

  reply	other threads:[~2008-01-18  1:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17 23:41 [PATCH] Remove vfs_init_caches_early() Rusty Russell
2008-01-18  1:15 ` Rusty Russell [this message]
2008-01-18  1:16 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801181215.20491.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.