From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
Subject: RE: [PATCH] 3.1.3 (and ??) timer_mode fix in xend
	for	virt-install
Date: Fri, 18 Jan 2008 15:39:55 -0700
Message-ID: <20080118153955750.00000001968@djm-pc>
References: <20080118222050.GF25808@redhat.com>
Reply-To: "dan.magenheimer@oracle.com" <dan.magenheimer@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080118222050.GF25808@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Daniel P. Berrange" <berrange@redhat.com>, Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

> So either we need to make sure that 'platform' gets a default value
> set for 'timer_mode', or make the hvm_set_param() call conditional
> like
> =

>    if self.info["platform"].get("timer_mode") is not None:
>        xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
>                   long(self.info["platform"].get("timer_mode")))
> =

> I assume the Hypervisor itself already has a default timemode value,
> so making this set_param conditional is probably easiest.

Yes, this is much nicer.

Thanks,
Dan