All of lore.kernel.org
 help / color / mirror / Atom feed
From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/cmirror/src cluster.c
Date: 18 Jan 2008 21:00:17 -0000	[thread overview]
Message-ID: <20080118210017.24557.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL5
Changes by:	jbrassow at sourceware.org	2008-01-18 21:00:16

Modified files:
	cmirror/src    : cluster.c 

Log message:
	- fix seg fault if there are pending checkpoint requests when a mirror
	is shutdown.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror/src/cluster.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.1.2.9&r2=1.1.2.10

--- cluster/cmirror/src/Attic/cluster.c	2008/01/18 17:11:07	1.1.2.9
+++ cluster/cmirror/src/Attic/cluster.c	2008/01/18 21:00:15	1.1.2.10
@@ -46,6 +46,7 @@
 
 	/* Are we the first, or have we received checkpoint? */
 	int valid;
+	int free_me;
 	struct queue *startup_queue;
 
 	int checkpoints_needed;
@@ -578,6 +579,11 @@
 		if (r != SA_AIS_OK)
 			LOG_ERROR("cpg_dispatch failed: %d", r);
 
+		if (entry->free_me) {
+			free(entry);
+			continue;
+		}
+
 		for (cp = entry->checkpoint_list; cp;) {
 			LOG_ERROR("Checkpoint data available for node %u",
 				  cp->requester);
@@ -810,7 +816,7 @@
 				LOG_ERROR("Startup items remain in cluster log");
 
 			free(match->startup_queue);
-			free(match);
+			match->free_me = 1;
 
 			goto out;
 		}			



             reply	other threads:[~2008-01-18 21:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18 21:00 jbrassow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-02-05 23:25 [Cluster-devel] cluster/cmirror/src cluster.c jbrassow
2007-11-19 18:00 jbrassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118210017.24557.qmail@sourceware.org \
    --to=jbrassow@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.