From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [PATCH] 3.1.3 (and ??) timer_mode fix in xend for
	virt-install
Date: Fri, 18 Jan 2008 22:20:50 +0000
Message-ID: <20080118222050.GF25808@redhat.com>
References: <20080118215927.GE25808@redhat.com>
	<20080118151316625.00000001968@djm-pc>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20080118151316625.00000001968@djm-pc>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jan 18, 2008 at 03:13:16PM -0700, Dan Magenheimer wrote:
> > so can't confirm that yet. I'll try and reproduce it - what 
> > error were you getting
> > when trying to create a VM ?  libvirt doesn't specify any 
> > timer_mode parameter
> > when creating VMs, so it should use whatever XenD's default 
> > is for that.
> 
> Traceback below.
> 
> Yeah, I'm no parseltongue but I think the default wasn't
> specified properly.
> 
> Note also that I am using python-virtinst-0.99 so maybe
> the interface to the XendServer has changed in more recent
> releases and wouldn't provoke the problem?
> 
> Dan
> 
> 
> Starting install...
> libvir: Xen Daemon error : GET operation failed:
> libvir: Xen Daemon error : POST operation failed: (xend.err 'Error creating doma
> in: long() argument must be a string or a number')

Ok this is useful. I'd say that message comes from this:

             xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
                  long(self.info["platform"].get("timer_mode")))


And that 'self.info["platform"].get("timer_mode")' is returning None,
causing the long() cal to fail. 

So either we need to make sure that 'platform' gets a default value
set for 'timer_mode', or make the hvm_set_param() call conditional
like

   if self.info["platform"].get("timer_mode") is not None:
       xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
                  long(self.info["platform"].get("timer_mode")))

I assume the Hypervisor itself already has a default timemode value,
so making this set_param conditional is probably easiest.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|