From: Rusty Russell <rusty@rustcorp.com.au>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Ash Willis <ashwillis@programmer.net>,
linux-pcmcia@lists.infradead.org
Subject: Re: [PATCH 1/3] Improve type handling in interrupt handlers
Date: Sat, 19 Jan 2008 09:11:14 +1100 [thread overview]
Message-ID: <200801190911.15106.rusty@rustcorp.com.au> (raw)
In-Reply-To: <47910F05.8040501@pobox.com>
On Saturday 19 January 2008 07:41:41 Jeff Garzik wrote:
> You should be using irq_handler_t for all these.
Well, these are your drivers, but for mine I dislike the obfuscation.
It's not like you can declare the function itself to be an irq_handler_t, so
it's a strange turd to drop in a driver.
> (Coincedentally, doing so makes it easier for me to later on remove the
> almost-never-used 'irq' argument from all irq handlers)
Slightly, but the compiler would tell you if you miss one, so I don't think
this is real.
Cheers,
Rusty.
next prev parent reply other threads:[~2008-01-18 22:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 20:22 [PATCH 1/3] Improve type handling in interrupt handlers Rusty Russell
2008-01-18 20:25 ` [PATCH 2/3] Make IRQ handlers typesafe Rusty Russell
2008-01-18 20:27 ` [PATCH 3/3] Makes lguest's irq handler typesafe Rusty Russell
2008-01-18 20:45 ` Jeff Garzik
2008-01-18 22:17 ` Rusty Russell
2008-01-18 22:17 ` Rusty Russell
2008-01-18 20:45 ` Jeff Garzik
2008-01-18 23:12 ` Tejun Heo
2008-01-18 23:12 ` Tejun Heo
2008-01-19 1:28 ` Rusty Russell
2008-01-19 1:40 ` Tejun Heo
2008-01-19 1:40 ` Tejun Heo
2008-01-19 1:44 ` Tejun Heo
2008-01-19 3:59 ` Rusty Russell
2008-01-19 3:59 ` Rusty Russell
2008-01-19 4:08 ` Tejun Heo
2008-01-19 4:08 ` Tejun Heo
2008-01-19 23:27 ` Rusty Russell
2008-01-19 23:27 ` Rusty Russell
2008-01-19 1:44 ` Tejun Heo
2008-01-19 1:28 ` Rusty Russell
2008-01-18 20:27 ` Rusty Russell
2008-01-18 20:43 ` [PATCH 2/3] Make IRQ handlers typesafe Jeff Garzik
2008-01-18 20:43 ` Jeff Garzik
2008-01-18 20:25 ` Rusty Russell
2008-01-18 20:41 ` [PATCH 1/3] Improve type handling in interrupt handlers Jeff Garzik
2008-01-18 22:11 ` Rusty Russell [this message]
2008-01-18 22:54 ` Jeff Garzik
2008-01-19 1:29 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801190911.15106.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=ashwillis@programmer.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.