From: Ingo Molnar <mingo@elte.hu>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: x86: remove casts
Date: Sat, 19 Jan 2008 15:08:17 +0100 [thread overview]
Message-ID: <20080119140817.GA4405@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0801191455180.27831@fbirervta.pbzchgretzou.qr>
* Jan Engelhardt <jengelh@computergmbh.de> wrote:
> On Jan 18 2008 11:45, Ingo Molnar wrote:
> >* Jan Engelhardt <jengelh@computergmbh.de> wrote:
> >
> >> This is against x86/mm.
> >
> >hm, it has checkpatch failures -
>
> All false positives.
no, not "All false positives", the first checkpatch failure is a blatant
ugliness that you introduced:
ERROR: use tabs not spaces
#137: FILE: arch/x86/kernel/microcode.c:248:
+^I^I EXT_SIGNATURE_SIZE * i;$
because you converted a tab to a sequence of 10 spaces:
- ext_sig = (struct extended_signature *)((void *)ext_header
- + EXT_HEADER_SIZE + EXT_SIGNATURE_SIZE * i);
+ ext_sig = (void *)ext_header + EXT_HEADER_SIZE +
+ EXT_SIGNATURE_SIZE * i;
<........>
(the second checkpatch warning is a false positive.)
and i applied your patch before i notified you, but apparently you
couldnt be bothered to check. Please do not bother to send patches with
such an attitude, it's just a waste of people's time.
Ingo
next prev parent reply other threads:[~2008-01-19 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 21:15 x86: remove casts Jan Engelhardt
2008-01-16 22:20 ` Kyle McMartin
2008-01-16 22:57 ` Jan Engelhardt
2008-01-17 6:43 ` Kyle McMartin
2008-01-17 22:22 ` Jan Engelhardt
2008-01-18 10:45 ` Ingo Molnar
2008-01-19 13:56 ` Jan Engelhardt
2008-01-19 14:08 ` Ingo Molnar [this message]
2008-01-19 14:26 ` Jan Engelhardt
2008-01-22 10:06 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080119140817.GA4405@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.