From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: venkatesh.pallipadi@intel.com, suresh.b.siddha@intel.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: ACPI early ioremap problems
Date: Sat, 19 Jan 2008 19:45:43 +0100 [thread overview]
Message-ID: <20080119184543.GA3751@elte.hu> (raw)
In-Reply-To: <20080119154651.GA1626@one.firstfloor.org>
* Andi Kleen <andi@firstfloor.org> wrote:
> On Sat, Jan 19, 2008 at 04:30:55PM +0100, Ingo Molnar wrote:
> > > > that case it's a 64-bit early_ioremap() bug that we want to find
> > > > even if ACPI didnt use early_ioremap().
> > > >
> > > > and this all runs before zap_low_mappings(), right?
> > >
> > > No after. Since some time x86-64 does the equivalent of z_l_m() in
> > > head64(); this means before start_kernel and definitely before
> > > setup_arch which sets up ACPI.
> >
> > that would mean early_ioremap() should switch to ioremap() after that
> > point. Could you try that, does it resolve the failure you are seeing?
>
> ioremap() does alloc_page and that won't work before paging_init().
> Early ACPI scan is before paging_init() because paging_init() needs
> node discovery at at least; which requires some ACPI tables.
hm, so are you saying that on 64-bit there's in essence no usable
ioremap facility between zap_low_mappings() and paging_init()?
(early_ioremap() is not usable anymore, and ioremap() is not yet
usable.) I guess we'll have to pick up the 32-bit early_ioremap() code
for 64-bit as well.
Ingo
next prev parent reply other threads:[~2008-01-19 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080119030843.GA2028@basil.nowhere.org>
[not found] ` <20080119150328.GA32370@elte.hu>
[not found] ` <20080119152649.GA1375@one.firstfloor.org>
2008-01-19 15:30 ` ACPI early ioremap problems Ingo Molnar
2008-01-19 15:46 ` Andi Kleen
2008-01-19 18:45 ` Ingo Molnar [this message]
2008-01-19 19:16 ` Andi Kleen
2008-01-20 16:48 ` ACPI early ioremap problems II Andi Kleen
2008-01-20 23:50 ` Ingo Molnar
2008-01-21 2:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080119184543.GA3751@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.