All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, tglx <tglx@linutronix.de>,
	akpm <akpm@linux-foundation.org>,
	johannes@sipsolutions.net
Subject: Re: [PATCH] hrtimer: fix section mismatch
Date: Sat, 19 Jan 2008 22:38:31 +0100	[thread overview]
Message-ID: <20080119213831.GF29070@uranus.ravnborg.org> (raw)
In-Reply-To: <20080119213146.GE29070@uranus.ravnborg.org>

On Sat, Jan 19, 2008 at 10:31:46PM +0100, Sam Ravnborg wrote:
> On Sat, Jan 19, 2008 at 11:57:10AM -0800, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Fix section mismatch in hrtimer.c:
> > 
> > WARNING: vmlinux.o(.text+0x50c61): Section mismatch: reference to .init.text: (between 'hrtimer_cpu_notify' and 'down_read_trylock')
> > 
> > Noticed by Johannes Berg and confirmed by Sam Ravnborg.
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

And looking at bit closer this looks like a 2.6.24 candidate.
With:
CONFIG_HOTPLUG=n
CONFIG_HOTPLUG_CPU=y

then we may see a call to init_hrtimers_cpu() from hrtimer_cpu_notify()
in the:
      case CPU_UP_PREPARE:
      case CPU_UP_PREPARE_FROZEN:
cases.

And this will oops.

[It these a cases will be hit I dunno - I just follow the
logic of the code here.]

	Sam

> 
> > ---
> >  kernel/hrtimer.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2.6.24-rc8-git2.orig/kernel/hrtimer.c
> > +++ linux-2.6.24-rc8-git2/kernel/hrtimer.c
> > @@ -1378,7 +1378,7 @@ sys_nanosleep(struct timespec __user *rq
> >  /*
> >   * Functions related to boot-time initialization:
> >   */
> > -static void __devinit init_hrtimers_cpu(int cpu)
> > +static void __cpuinit init_hrtimers_cpu(int cpu)
> >  {
> >  	struct hrtimer_cpu_base *cpu_base = &per_cpu(hrtimer_bases, cpu);
> >  	int i;
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2008-01-19 21:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-19 19:57 [PATCH] hrtimer: fix section mismatch Randy Dunlap
2008-01-19 21:31 ` Sam Ravnborg
2008-01-19 21:38   ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080119213831.GF29070@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.