From: Andi Kleen <andi@firstfloor.org>
To: mingo@elte.hu, Jeremy Fitzhardinge <jeremy@goop.org>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
venkatesh.pallipadi@intel.com
Subject: [PATCH] Fix early_ioremap on x86-64
Date: Sun, 20 Jan 2008 18:28:40 +0100 [thread overview]
Message-ID: <20080120172840.GA24608@basil.nowhere.org> (raw)
Fix early_ioremap on x86-64
[Venki, sorry for blaming PAT for this earlier. It was innocent.]
[Note the patch is on top of git-x86 + gbpages applied. I think
there will be an trivial reject without gbpages-direct applied first]
I had ACPI failures on several machines since a few days. Symptom
was NUMA nodes not getting detected or worse cores not getting detected.
They all came from ACPI not being able to read various of its tables. I finally
bisected it down to Jeremy's "put _PAGE_GLOBAL into PAGE_KERNEL" change.
With that the fix was fairly obvious. The problem was that early_ioremap()
didn't use a "_all" flush that would affect the global PTEs too. So
with global bits getting used everywhere now an early_ioremap would
not actually flush a mapping if something else was mapped previously
on that slot (which can happen with early_iounmap inbetween)
This patch changes all flushes in init_64.c to be __flush_tlb_all()
and fixes the problem here.
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/x86/mm/init_64.c
===================================================================
--- linux.orig/arch/x86/mm/init_64.c
+++ linux/arch/x86/mm/init_64.c
@@ -242,7 +242,7 @@ void *early_ioremap(unsigned long addr,
addr &= PMD_MASK;
for (i = 0; i < pmds; i++, addr += PMD_SIZE)
set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
- __flush_tlb();
+ __flush_tlb_all();
printk(KERN_CONT "%016ld\n", vaddr);
return (void *)vaddr;
next:
@@ -265,7 +265,7 @@ void early_iounmap(void *addr, unsigned
pmd = level2_kernel_pgt + pmd_index(vaddr);
for (i = 0; i < pmds; i++)
pmd_clear(pmd + i);
- __flush_tlb();
+ __flush_tlb_all();
}
static unsigned long direct_entry(unsigned long paddr)
@@ -339,7 +339,7 @@ static void __meminit phys_pud_init(pud_
spin_unlock(&init_mm.page_table_lock);
unmap_low_page(pmd);
}
- __flush_tlb();
+ __flush_tlb_all();
}
static void __init find_early_table_space(unsigned long end)
next reply other threads:[~2008-01-20 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-20 17:28 Andi Kleen [this message]
2008-01-20 17:59 ` [PATCH] Fix early_ioremap on x86-64 Ingo Molnar
2008-01-20 19:12 ` Andi Kleen
2008-01-21 0:20 ` Ingo Molnar
2008-01-20 18:04 ` [PATCH] Fix early_ioremap on x86-64 II Andi Kleen
2008-01-21 19:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080120172840.GA24608@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.