From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JGuvg-0005it-P2 for mharc-grub-devel@gnu.org; Mon, 21 Jan 2008 06:35:04 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGuve-0005hZ-3x for grub-devel@gnu.org; Mon, 21 Jan 2008 06:35:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGuvc-0005gH-0Q for grub-devel@gnu.org; Mon, 21 Jan 2008 06:35:01 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGuvb-0005g5-Kt for grub-devel@gnu.org; Mon, 21 Jan 2008 06:34:59 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JGuva-0001ZY-T9 for grub-devel@gnu.org; Mon, 21 Jan 2008 06:34:59 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JGuvY-0000MP-0f; Mon, 21 Jan 2008 12:34:58 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JGutr-00026K-84; Mon, 21 Jan 2008 12:33:11 +0100 Date: Mon, 21 Jan 2008 12:33:11 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080121113311.GB7949@thorin> References: <20080112031444.GA30703@thorin> <87hchf2ulp.fsf@xs4all.nl> <20080115120643.GD31275@thorin> <20080115163612.GA4905@thorin> <87d4rvxyq3.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d4rvxyq3.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: devel@lists.laptop.org Subject: Re: GRUB on OLPC / XO X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2008 11:35:02 -0000 On Mon, Jan 21, 2008 at 11:24:52AM +0100, Marco Gerards wrote: > > > > _start: 0x10000, _end: 0x1f804 > > Using memory for heap: addr=0x100000, end=0x400000 > > Using memory for heap: addr=0x2000, end=0x9ffff > > Welcome to GRUB! > > > > See how our core image and the second heap chunk overlap. I'm not sure if this > > is a bug in OFW's /memory/available, but in any case it doesn't hurt to add a > > generic sanity check in our memory manager to avoid this sort of breakage. > > > > It's also be useful to protect our own stack, etc.. > > > > What do you think? > > At least some kind of check should be available. It could also be in > init.c. Yep. I concluded that there's nothing usefuly portable about having this in kern/, and proposed: [PATCH] safety check in claim_heap() see my other mail below. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)