From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JGyw8-0000tV-D1 for mharc-grub-devel@gnu.org; Mon, 21 Jan 2008 10:51:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGyw6-0000sj-Dp for grub-devel@gnu.org; Mon, 21 Jan 2008 10:51:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGyw1-0000oO-5L for grub-devel@gnu.org; Mon, 21 Jan 2008 10:51:45 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGyw0-0000o9-Ti for grub-devel@gnu.org; Mon, 21 Jan 2008 10:51:40 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JGyw0-0006xE-Nf for grub-devel@gnu.org; Mon, 21 Jan 2008 10:51:40 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JGyvx-0000hm-G0 for grub-devel@gnu.org; Mon, 21 Jan 2008 16:51:39 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JGyuD-0001vK-B1 for grub-devel@gnu.org; Mon, 21 Jan 2008 16:49:49 +0100 Date: Mon, 21 Jan 2008 16:49:49 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080121154949.GB6988@thorin> References: <20080121144458.GA5144@thorin> <878x2jw76n.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878x2jw76n.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] abort when core.img is too big X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2008 15:51:46 -0000 On Mon, Jan 21, 2008 at 04:05:04PM +0100, Marco Gerards wrote: > Robert Millan writes: > > > With the addition of memdisk, it is too easy for user to create an image > > big enough that would corrupt upper memory (starting with vga region). This > > happens at roughly ~600 kiB memdisk size. > > > > This patch adds a check in grub-mkimage to prevent this. I did also take > > the opportunity to reuse the upper memory macro to avoid hardcoding its > > address for VGA stuff. > > > > Comments? > > This makes sense to me. Ok, committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)