From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JH0F3-0004LH-5d for mharc-grub-devel@gnu.org; Mon, 21 Jan 2008 12:15:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JH0F2-0004LC-7U for grub-devel@gnu.org; Mon, 21 Jan 2008 12:15:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JH0Ez-0004Ky-Rn for grub-devel@gnu.org; Mon, 21 Jan 2008 12:15:22 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JH0Ez-0004Kt-M8 for grub-devel@gnu.org; Mon, 21 Jan 2008 12:15:21 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JH0Ez-0006SN-0K for grub-devel@gnu.org; Mon, 21 Jan 2008 12:15:21 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JH0EZ-0000og-VZ for grub-devel@gnu.org; Mon, 21 Jan 2008 18:15:03 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JH0Bb-0000sU-P6 for grub-devel@gnu.org; Mon, 21 Jan 2008 18:11:51 +0100 Date: Mon, 21 Jan 2008 18:11:51 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080121171151.GA3343@thorin> References: <20080115171747.GA14625@thorin> <1200418959.17542.6.camel@dv> <20080115180055.GA21551@thorin> <87prvv863n.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87prvv863n.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] improve grub_mm_init_region() debug message X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2008 17:15:24 -0000 On Mon, Jan 21, 2008 at 06:02:20PM +0100, Marco Gerards wrote: > Robert Millan writes: > > > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: > >> > >> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: > >> > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", > >> > addr, (unsigned int) size); > >> > + grub_dprintf ("mem", "Using memory for heap: start=%p, end=%p\n", > >> > addr, addr + size); > >> > >> Maybe addr+size-1 would be better? Inclusive boundaries are more > >> intuitive. Just run "cat /proc/iomem" to see what I mean. > > > > Sounds better to me. > > > > Does this change (with addr + size -1) sound fine to everyone else? > > Why not showing both the range and the size. Isn't the size useful > sometimes? When? What you typicaly want to debug is whether your mem region overlaps with something else, or so. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)