Re: sym53c8xx ISTAT1 feature never set

[Mike Anderson <andmike@linux.vnet.ibm.com>]

Matthew Wilcox <matthew@wil.cx> wrote:
> The only problem is ... we never set the FE_ISTAT1 bit.  Mike tells me
> that when he sets it, it makes his error recovery work.
> 
> I think we need a patch somewhat along these lines:
> 
>   {PCI_DEVICE_ID_LSI_53C1010_66, 0xff, "1010-66", 6, 31, 7, 8,
>   FE_WIDE|FE_ULTRA3|FE_QUAD|FE_CACHE_SET|FE_BOF|FE_DFBC|FE_LDSTR|FE_PFEN|
>   FE_RAM|FE_RAM8K|FE_64BIT|FE_DAC|FE_IO256|FE_NOPM|FE_LEDC|FE_66MHZ|FE_CRC|
> - FE_C10|FE_U3EN}
> + FE_C10|FE_U3EN|FE_ISTAT1}

As you already mentioned we tested setting FE_ISTAT1 for one card. We just
ran with your patch and it addressed that issue as expected (as this patch
only enables more cards that we do not have it not that interesting that it
passed, just wanted to add a "tested" to this thread). I can only hardware
verify the check above "PCI_DEVICE_ID_LSI_53C1010_66", so that does not
add much.

-andmike
--
Michael Anderson
andmike@linux.vnet.ibm.com