All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Johannes Weiner <hannes@saeurebad.de>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, Zan Lynx <zlynx@acm.org>,
	Thomas Gleixner <tglx@linutronix.de>, Len Brown <lenb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: echo mem > /sys/power/state
Date: Mon, 21 Jan 2008 23:37:56 +0100	[thread overview]
Message-ID: <20080121223756.GA15875@elf.ucw.cz> (raw)
In-Reply-To: <878x2k53iz.fsf@saeurebad.de>

Hi!

> > index f7dfff2..e5693d6 100644
> > --- a/kernel/power/Makefile
> > +++ b/kernel/power/Makefile
> > @@ -5,7 +5,7 @@ endif
> >  
> >  obj-y				:= main.o
> >  obj-$(CONFIG_PM_LEGACY)		+= pm.o
> > -obj-$(CONFIG_PM_SLEEP)		+= process.o console.o
> > +obj-$(CONFIG_PM_SLEEP)		+= process.o console.o sleepy.o
> 
> Why compiling it uncoditionally?  What would be wrong with

Its part of my world domination plan ;-).

> > +extern int set_alarm(int length);
> 
> Huh?

Set alarm belongs in drivers/rtc, moved now.

> > +	alarm = now+length;
> > +	rtc_time_to_tm(alarm, &alm.time);
> > +
> > +	retval = cmos_set_alarm(rtc, &alm);
> 
> cmos_set_alarm() takes a struct device * too.

Fixed.

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-01-21 22:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17  6:24 echo mem > /sys/power/state Andrew Morton
2008-01-17 17:36 ` Zan Lynx
2008-01-17 19:13   ` Andrew Morton
2008-01-17 21:38     ` Rafael J. Wysocki
2008-01-17 21:45       ` Nigel Cunningham
2008-01-17 22:27         ` Rafael J. Wysocki
2008-01-18  8:36       ` Ingo Molnar
2008-01-18  8:47         ` Andrew Morton
2008-01-18  9:04           ` Harvey Harrison
2008-01-18 12:18           ` Ingo Molnar
2008-01-18 14:26             ` Rafael J. Wysocki
2008-01-20 23:39             ` Pavel Machek
2008-01-20 23:42               ` Ingo Molnar
2008-01-21  0:31                 ` Pavel Machek
2008-01-21  2:13                   ` Johannes Weiner
2008-01-21 22:37                     ` Pavel Machek [this message]
2008-01-22 14:42                       ` Ingo Molnar
2008-01-23 21:27                         ` Pavel Machek
2008-01-17 21:48     ` Jiri Slaby
2008-01-18  8:51       ` Ingo Molnar
2008-01-17 18:22 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080121223756.GA15875@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@saeurebad.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=zlynx@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.