From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 2.6.24-rc8] spi: s3c drivers shouldn't care about spi_board_info Date: Tue, 22 Jan 2008 00:09:11 -0800 Message-ID: <20080122000911.4b61af5c.akpm@linux-foundation.org> References: <200801212341.07086.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ben Dooks , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Brownell Return-path: In-Reply-To: <200801212341.07086.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Mon, 21 Jan 2008 23:41:06 -0800 David Brownell wrote: > The two S3C SPI master drivers got merged without much review, so > I just noticed that they're doing something that the SPI core code > is responsible for, rather than any adapter driver: they try to > register SPI devices. err, but these driver predate the generic SPI core, I think? > drivers/spi/spi_s3c24xx.c | 12 ------------ > drivers/spi/spi_s3c24xx_gpio.c | 12 ------------ > include/asm/arch/spi-gpio.h | 6 ------ > include/asm/arch/spi.h | 6 ------ argh, please don't do that. It looks like this is referring to include/asm-arm/arch-s3c2410/ ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/