From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 22 Jan 2008 03:11:14 +0000 Subject: Re: [PATCH] spi: add support for SPI over SuperH SCI pins Message-Id: <20080122031114.GA2062@linux-sh.org> List-Id: References: <20080121104913.11908.50319.sendpatchset@clockwork.opensource.se> <200801211429.29906.david-b@pacbell.net> In-Reply-To: <200801211429.29906.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Brownell Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Magnus Damm , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Mon, Jan 21, 2008 at 02:29:29PM -0800, David Brownell wrote: > On Monday 21 January 2008, Magnus Damm wrote: > > +struct sh_sci_spi { > > + struct spi_bitbang bitbang; > > + > > + unsigned long mapbase; > > Not "void __iomem *mapbase"? > > I notice that you're not doing an ioremap() to get this address. > Is the platform device properly registering a *physical* address > in the IORESOURCE_MEM record for the device? > It should be ioremap(), yes. While for these parts ioremap() doesn't really do anything, it still takes care of the void __iomem * casting properly, and there are in fact parts where we have no choice but to go through page tables anyways. > > +#define spidelay(x) ndelay(x) > > + > > +#define EXPAND_BITBANG_TXRX > > +#include > > + This is rather unorthodox.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH] spi: add support for SPI over SuperH SCI pins Date: Tue, 22 Jan 2008 12:11:14 +0900 Message-ID: <20080122031114.GA2062@linux-sh.org> References: <20080121104913.11908.50319.sendpatchset@clockwork.opensource.se> <200801211429.29906.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Magnus Damm , linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Brownell Return-path: Content-Disposition: inline In-Reply-To: <200801211429.29906.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Mon, Jan 21, 2008 at 02:29:29PM -0800, David Brownell wrote: > On Monday 21 January 2008, Magnus Damm wrote: > > +struct sh_sci_spi { > > + struct spi_bitbang bitbang; > > + > > + unsigned long mapbase; > > Not "void __iomem *mapbase"? > > I notice that you're not doing an ioremap() to get this address. > Is the platform device properly registering a *physical* address > in the IORESOURCE_MEM record for the device? > It should be ioremap(), yes. While for these parts ioremap() doesn't really do anything, it still takes care of the void __iomem * casting properly, and there are in fact parts where we have no choice but to go through page tables anyways. > > +#define spidelay(x) ndelay(x) > > + > > +#define EXPAND_BITBANG_TXRX > > +#include > > + This is rather unorthodox.. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/